[fix] #4565 When using MSVC to compile v12.0.0, many compilation warn… #4572
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n warnings are generated
|
@vitaut |
vitaut
requested changes
Oct 11, 2025
| size += grouping.count_separators(exp); | ||
| return write_padded<Char, align::right>( | ||
| out, specs, to_unsigned(size), [&](iterator it) { | ||
| out, specs, to_unsigned(static_cast<size_t>(size)), [&](iterator it) { |
There was a problem hiding this comment.
Let's remove to_unsigned since with the cast the argument is already unsigned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@esoft-com This warning occurs because on x86 Windows, size_t is a 32-bit unsigned integer, while unsigned __int64 is a 64-bit unsigned integer. Implicitly converting from unsigned __int64 to size_t can cause data loss, so MSVC emits warning C4244.
To resolve this, we should explicitly cast the value to size_t wherever the conversion happens, ideally at the point where the warning is triggered. thank you for checking the code