Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format std::reference_wrapper #4163

Closed
wants to merge 1 commit into from
Closed

format std::reference_wrapper #4163

wants to merge 1 commit into from

Conversation

yfeldblum
Copy link
Contributor

No description provided.

@yfeldblum yfeldblum force-pushed the feature-format-reference-wrapper branch from 70a98ee to 9913c35 Compare September 16, 2024 19:25
phprus
phprus reviewed Sep 16, 2024
View reviewed changes
include/fmt/std.h Outdated Show resolved Hide resolved
@yfeldblum yfeldblum force-pushed the feature-format-reference-wrapper branch from 9913c35 to 8fac8c2 Compare September 16, 2024 21:19
@yfeldblum yfeldblum force-pushed the feature-format-reference-wrapper branch from 8fac8c2 to 1550bdc Compare September 16, 2024 21:20
@vitaut
Copy link
Contributor

vitaut commented Sep 17, 2024 •
edited
Loading

Merged in 07e7015 with a minor formatting tweak to make clang-format happy. Thanks!

@vitaut vitaut closed this Sep 17, 2024
@sunmy2019
Copy link
Contributor

adding format_as to namespace std is undefined.

https://en.cppreference.com/w/cpp/language/extending_std

@phprus phprus mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phprus phprus phprus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yfeldblum @vitaut @sunmy2019 @phprus