Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DLL visibility of explicit instantiation "declaration" of internal::basic_data<void> in header format.h and the explicit instantiation "definition" in format.cc #1134

Merged
merged 8 commits into from
May 2, 2019
+13 −15
Merged

Fix DLL visibility of explicit instantiation "declaration" of internal::basic_data<void> in header format.h and the explicit instantiation "definition" in format.cc #1134

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
01bb881
Update format.cc
denchat Apr 28, 2019
3944deb
Mirror visibility of explicit instantiation declaration
denchat Apr 29, 2019
e4bd8c1
Eliminate `__declspec(dllexport)` designation on extern template inte…
denchat Apr 30, 2019
4f919b8
Add `FMT_EXTERN_TEMPLATE_API` for designate DLL export `extern template`
denchat May 2, 2019
c6e6bfe
Delete whole `FMT_USE_EXTERN_TEMPLATES` block and its condition
denchat May 2, 2019
b4a4dcd
Add `#define FMT_EXTERN extern` only when not `FMT_HEADER_ONLY`
denchat May 2, 2019
7d0dd76
Replace `extern` on basic_data<void> with the `FMT_EXTERN` condition …
denchat May 2, 2019
c3d87c5
replace misspelled if !define() with ifndef
denchat May 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update format.cc 
As the explicit instantiation *declaration* of `internal::basic_data<void>` in format.h, this explicit instantiation *definition* should mirror FMT_API also.
  • Loading branch information
@denchat
denchat authored Apr 28, 2019
commit 01bb881ff2460e316cfb84a1a91da1dba78b6dc4
2 changes: 1 addition & 1 deletion src/format.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include "fmt/format-inl.h"

FMT_BEGIN_NAMESPACE
template struct internal::basic_data<void>;
template struct FMT_API internal::basic_data<void>;

// Workaround a bug in MSVC2013 that prevents instantiation of grisu_format.
bool (*instantiate_grisu_format)(double, internal::buffer<char>&, int, unsigned,
Expand Down