Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use fallback string_view to pass format string #664

Closed
vitaut opened this issue Feb 24, 2018 · 1 comment
Closed

Always use fallback string_view to pass format string #664

vitaut opened this issue Feb 24, 2018 · 1 comment

Comments

@vitaut
Copy link
Contributor

vitaut commented Feb 24, 2018 •
edited
Loading

As discussed in https://gitter.im/fmtlib/fmt, there can be mismatch between -std options in user and library code. A simple solution is to always pass format string as fallback string_view.
@alabuzhev
Copy link
Contributor

Always using the fallback implementation should also resolve #657.

vitaut added a commit that referenced this issue Feb 24, 2018
@vitaut
Always use fallback string_view to pass format string (#664)
4d35f94
@vitaut vitaut closed this as completed Feb 24, 2018
This was referenced Feb 24, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @alabuzhev