Skip to content

format-impl-test fails to link using MacPorts Clang #1461

Closed
@jwillikers

Description

@jwillikers

On macOS, the format-impl-test fails to link when using the MacPorts Clang compiler. This is due to the "ifdef apple_build_version" check in the format-impl-test.cc file for value_extractor class. This only checks if the Clang compiler is Apple's Clang, but not whether Apple's libc++ is being linked. Simply replacing the macro with TARGET_OS_MAC corrects my issue, but I don't think this is very robust. I recommend using CMake's CheckCXXSourceRuns to reliably detect whether __int128_t and __uint128_t are available.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions