Skip to content

Conversation

@fmind
Copy link
Owner

@fmind fmind commented Mar 4, 2025

Closes #36

@fmind fmind added feat A new feature. Correlates with MINOR in SemVer breaking A breaking change. Correlates with MAJOR in SemVer labels Mar 4, 2025
@fmind fmind added this to the v4.0.0 milestone Mar 4, 2025
@fmind fmind self-assigned this Mar 4, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @fmind, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses issue #36 by switching the task management system from pyinvoke to just. This involves removing invoke and introducing just for defining and running project tasks. The changes include updating the GitHub Actions workflows, pre-commit configuration, README, pyproject.toml, and task definitions to reflect this transition.

Highlights

  • Task Management System Migration: Replaces pyinvoke with just for task automation, aiming for a simpler and more straightforward task definition.
  • GitHub Actions Workflow Updates: Modifies the CI/CD workflows (check.yml, publish.yml) to use just commands instead of invoke.
  • Pre-commit Configuration: Updates .pre-commit-config.yaml to include bandit and upgrades the revisions of pre-commit-hooks and commitizen.
  • README Modifications: Updates the README to reflect the change from pyinvoke to just, including updated command examples and task descriptions.
  • Dependency Management: Removes invoke and adds rust-just as a development dependency in pyproject.toml. Also, adds hatchling as a dependency.
  • Task Definition Restructuring: Replaces the invoke.yaml and tasks/*.py files with a single justfile that defines all project tasks.

Changelog

Click here to see the changelog
  • .github/actions/setup/action.yml
    • Updates the setup-uv action version from v4 to v5.
  • .github/workflows/check.yml
    • Replaces invoke commands with just commands for running checks (format, type, code, security, coverage).
    • Changes the uv sync group from checks to check.
  • .github/workflows/publish.yml
    • Replaces invoke commands with just commands for documentation and package building.
    • Changes the uv sync group from docs to doc.
  • .pre-commit-config.yaml
    • Updates the revision of pre-commit-hooks to v5.0.0.
    • Adds bandit hook for security checks.
    • Updates the revision of commitizen to v4.4.1.
  • README.md
    • Updates references from PyInvoke to Just in the Automation section.
    • Replaces Pyenv with Uv in the Programming section.
    • Updates command examples to use just instead of inv.
    • Replaces the list of available tasks with a TOML-style configuration example for just.
    • Updates descriptions and alternatives for task automation.
  • invoke.yaml
    • Removes the invoke.yaml file as invoke is no longer used.
  • justfile
    • Adds a justfile to define project tasks using just syntax, including tasks for checking, cleaning, committing, documenting, containerizing, formatting, installing, managing MLflow, packaging, and project management.
  • mlops-python-package.code-workspace
    • Removes the vsc-invoke extension recommendation.
  • pyproject.toml
    • Moves license and keywords to be before requires-python.
    • Adds hatchling as a dependency.
    • Renames dependency group checks to check.
    • Replaces invoke with rust-just in the dev dependency group.
    • Renames dependency group docs to doc.
    • Renames dependency group notebooks to notebook.
    • Updates default-groups in tool.uv to reflect the dependency group renames.
  • python_env.yaml
    • Removes the python_env.yaml file.
  • requirements.txt
    • Removes the requirements.txt file.
  • tasks/init.py
    • Removes the tasks/__init__.py file.
  • tasks/check.just
    • Adds a tasks/check.just file.
  • tasks/checks.py
    • Removes the tasks/checks.py file.
  • tasks/clean.just
    • Adds a tasks/clean.just file.
  • tasks/cleans.py
    • Removes the tasks/cleans.py file.
  • tasks/commit.just
    • Adds a tasks/commit.just file.
  • tasks/commits.py
    • Removes the tasks/commits.py file.
  • tasks/containers.py
    • Removes the tasks/containers.py file.
  • tasks/doc.just
    • Adds a tasks/doc.just file.
  • tasks/docker.just
    • Adds a tasks/docker.just file.
  • tasks/docs.py
    • Removes the tasks/docs.py file.
  • tasks/format.just
    • Adds a tasks/format.just file.
  • tasks/formats.py
    • Removes the tasks/formats.py file.
  • tasks/install.just
    • Adds a tasks/install.just file.
  • tasks/installs.py
    • Removes the tasks/installs.py file.
  • tasks/mlflow.just
    • Adds a tasks/mlflow.just file.
  • tasks/mlflow.py
    • Removes the tasks/mlflow.py file.
  • tasks/package.just
    • Adds a tasks/package.just file.
  • tasks/packages.py
    • Removes the tasks/packages.py file.
  • tasks/project.just
    • Adds a tasks/project.just file.
  • tasks/projects.py
    • Removes the tasks/projects.py file.
  • uv.lock
    • Updates the uv.lock file to reflect the changes in dependencies, including the removal of invoke and the addition of rust-just and hatchling.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Did you know?

The just command runner is written in Rust, a systems programming language known for its speed, safety, and concurrency.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces significant improvements to the project, including updating the Python version, transitioning from PyInvoke to Just for task management, updating dependencies, and enhancing data validation in core models. The changes are well-structured and contribute to the project's maintainability, efficiency, and reliability.

Summary of Findings

  • Python Version Updates: The pull request updates the Python version from 3.12 to 3.13 across multiple files, ensuring the project uses the latest features and improvements. This is a good practice for maintaining the project's currency and compatibility.
  • Dependency Updates: The pull request updates various dependencies in pyproject.toml to their latest versions, ensuring the project benefits from the latest features, bug fixes, and security patches. This is crucial for maintaining the project's stability and security.
  • Transition from PyInvoke to Just: The pull request transitions the project's task management from PyInvoke to Just, which offers a more straightforward and efficient syntax for defining and executing tasks. This simplifies the project's automation and improves developer experience.
  • Removal of python_env.yaml and requirements.txt: The pull request removes the python_env.yaml and requirements.txt files, relying instead on uv and pyproject.toml for managing dependencies. This streamlines the project's dependency management and reduces redundancy.
  • Improved Error Handling in AlertsService: The pull request improves error handling in the AlertsService by printing a message to the console when notifications are not supported, rather than raising a warning. This provides a more user-friendly experience.
  • Data Validation in Core Models: The pull request introduces data validation using pandera schemas in the core models, ensuring data integrity and preventing unexpected errors. This enhances the project's robustness and reliability.

Merge Readiness

The pull request is in good shape to be merged. The changes are well-structured and contribute to the project's maintainability, efficiency, and reliability. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.

@fmind fmind merged commit 22a0380 into v4.0.0 Mar 4, 2025
1 check passed
@fmind fmind deleted the 36-feat-switch-from-pyinvoke-to-just branch March 4, 2025 20:10
fmind added a commit that referenced this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking A breaking change. Correlates with MAJOR in SemVer feat A new feature. Correlates with MINOR in SemVer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants