-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fs subcycle cfl fix #307
Merged
Merged
Fs subcycle cfl fix #307
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
05618dd
Re-compute moments
galfthan 4a934ad
Merge remote-tracking branch 'ykempf/fix_test_fp'
ursg 586eb32
Simple cfl check with allreduce at each substep/subcycle fo the field…
ykempf 5425f22
Fixed several errors in the previous version.
ykempf 9ba21f3
Removed testing MPI_Barrier().
ykempf 2dce06f
Fixed warning message to be more informative and correct.
ykempf a1c015b
Put logfile in use in fieldsolver subcycling reporting.
ykempf 58d4add
Removed dodgy bailout::min_dt threshold in fieldsolver subcycling.
ykempf 58dbef2
Second logfile entry for fieldsolver subcycling.
ykempf 086d903
Switched to a local variable in propagateFields.
ykempf 060b1b7
Fixed the final substep length issue, commented.
ykempf 551f488
Change subcycle dt only if it would exceed cfl.
ykempf 6669eeb
New fs subcylce algorithm, not tested yet
galfthan dd2b5eb
Two typos fixed from previous commit. Now compiles.
ykempf 0752798
Fixup commit, i was renamed to subcycleCount in ldz_main.
ursg 86c8a81
Interface change to calculateWaveSpeed functions.
ykempf f0a986e
Split upwinding and CFL velocities in LDZ solver.
ykempf ed91312
Version with Hall in cfl but not upwinding.
ykempf a174e64
Blunt Runge Kutta second order substepping.
ykempf d545f30
Merge remote-tracking branch 'upstream/master' into fix_update_moment…
galfthan 6fe1585
Two new testcases with subcycles for the testpackage.
ursg 3d54bb6
Added map include so that it compiles on sisu
galfthan 5d30d94
Merge pull request #309 from galfthan/fix_sisu_compilation
galfthan 70abfd8
Fix typo ist test_fp_substeps testpackage.
ursg 6dc23c1
Removed commented code, added one explanation comment.
ykempf 9625c7c
Calculate acc- and fieldsolver subcycles even when running with fixed dt
ursg 60ae054
Calculate acc- and fieldsolver subcycles even when running with fixed dt
ursg a51dab8
Still output dt calculation results, even if it is not being used.
ursg 0919389
Added map include so that it compiles on sisu
galfthan 2e9bc7a
Updated Dispersion.
ykempf 1cbee6f
CFL wave speeds in field solver: scheme and interface change.
ykempf 4f93c95
Added new polar test, and replaced old acc_1.
galfthan 29c701b
Enable new test to run
galfthan 8a6c8bd
Merge pull request #305 from ykempf/field_solver_stepping_improvements
ursg 4ed3ddd
Still output dt calculation results, even if it is not being used.
ursg 7aedaf8
Merge pull request #311 from ursg/testpackage_subcycles
ursg b608fb7
Merge pull request #308 from galfthan/fix_update_moments_in_acc
ursg dffbd6c
Merge branch 'fs_subcycle_cfl_fix' with current master.
ursg 989267c
Remove superfluous second calculation of moment derivatives per subcycle
ursg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is, until we interpolate moments in time as Sebastian wants us to do since last summer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, but that doesn't happen yet, so this is, for now, correct.
I would suggest merging this now, if there are no other objections.