-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix refine/coarsen logging #1036
base: dev
Are you sure you want to change the base?
Conversation
So the counts still don't quite add up. According to this line: The easiest workaround might be to actually store all siblings in this set, so that the reducet unrefine count would include all siblings, but change it so that when executing unrefines, siblings beyond the first are ignored. Thoughts? |
I suppose one part of the question is: do we actually need the exact values? But I fear part of the answer is: as soon as we decide that "no", next week we'll start debugging a case that will require the actually correct values. So... I suppose we do want them? |
I could just refactor the loop on https://github.com/fmihpc/dccrg/blob/d7a7746bcbcf53909acfd85d19dd29de8b0f123a/dccrg.hpp#L3503 earlier on, like the end of |
Use correct datatype for logging coarsened cells. Oops...