Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPAConfig: generalize reference path handling #187

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

imagejan
Copy link
Member

@imagejan imagejan commented Oct 9, 2024

  • Remove: resolve_with_git_root, make_relative_to_git_root
  • Add: resolve_with_reference, make_relative
  • Use IPAConfig.reference_dir to resolve paths
  • Also resolve path inputs from defaults in prompt_with_questionary

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.69%. Comparing base (eb0f5ce) to head (d59db98).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   93.47%   93.69%   +0.22%     
==========================================
  Files          55       55              
  Lines        3630     3630              
  Branches      376      229     -147     
==========================================
+ Hits         3393     3401       +8     
+ Misses        223      216       -7     
+ Partials       14       13       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Remove: resolve_with_git_root, make_relative_to_git_root
* Add: resolve_with_reference, make_relative
* Use IPAConfig.reference_dir to resolve paths
* Also resolve path inputs from defaults in prompt_with_questionary
@imagejan imagejan force-pushed the generalize-ipaconfig-reference branch from 171c1d5 to d59db98 Compare October 9, 2024 11:31
@imagejan imagejan merged commit 6f50e6c into main Oct 9, 2024
12 checks passed
@imagejan imagejan deleted the generalize-ipaconfig-reference branch October 9, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant