Skip to content

Compat sio cleanups #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benatouba wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Compat sio cleanups #265

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca1e1ca
refactor(sio): remove basestring compatibility shim
benatouba Apr 19, 2026
42cc498
feat(types): annotate rotated projection health check
benatouba Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions salem/sio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,6 @@
except ImportError:
# xarray < v0.11
from xarray.backends.api import _default_lock as NETCDF4_PYTHON_LOCK
try:
from xarray.core.pycompat import basestring
except ImportError:
# latest xarray dropped python2 support, so we can safely assume py3 here
basestring = str

# Locals
from salem import transform_proj

Expand Down Expand Up @@ -1024,7 +1018,7 @@ def open_wrf_dataset(file, **kwargs):
return ds


def is_rotated_proj_working():
def is_rotated_proj_working() -> bool:

import pyproj
srs = ('+ellps=WGS84 +proj=ob_tran +o_proj=latlon '
Expand All @@ -1034,9 +1028,9 @@ def is_rotated_proj_working():
p1 = pyproj.Proj(srs)
p2 = wgs84

return np.isclose(transform_proj(p1, p2, -20, -9),
[-22.243473889042903, -0.06328365194179102],
atol=1e-5).all()
return bool(np.isclose(transform_proj(p1, p2, -20, -9),
[-22.243473889042903, -0.06328365194179102],
atol=1e-5).all())


def open_metum_dataset(file, pole_longitude=None, pole_latitude=None,
Expand Down Expand Up @@ -1165,7 +1159,7 @@ def open_mf_wrf_dataset(paths, chunks=None, compat='no_conflicts', lock=None,
xarray.Dataset
"""

if isinstance(paths, basestring):
if isinstance(paths, str):
paths = sorted(glob(paths))
if not paths:
raise IOError('no files to open')
Expand Down
Loading