Field with 0 value

[irt-msummers]

I have fields that have a value of 0 -- not null -- I think they should be displayed as $0.00

[fmaclen]

@irt-msummers Are you referring to the field Minimum or Misc2 in your screenshot?
And you were expecting it to say $0.00 (not as a placeholder)?

Same as in #55, can you post the props you are passing to the component so I can replicate the issue?

[fmaclen]

When the value is 0 you should get a placeholder that says $0.00, unless you pass the component placeholder: null.

You can see an example of it in the Amount field on this page where the default value is 0: https://demo.canutin.com/transaction/add

[irt-msummers]

<CurrencyInput name={id} bind:value={value} locale="en-US" currency="USD" placeholder={null}/>

My fault -- I didn't capture the screen correctly. Sell Price is the one I am referring to.

And I understand your logic, but -- 0 is a valid number just like 1 or 2 or whatever should it not be displayed the same way? If Sell Price were null or '' -- nor something non-numeric then yes it should have a place holder if you want placeholders. Yes/no?

[fmaclen]

I see what you mean, let me think about this a bit more.

[fmaclen]

I looked at other similar components (for React) and the described behavior in this issue is the default, which probably means that this should also be the default here.

Unfortunately changing this default might imply a breaking change which will need the library to be bumped a whole version. I have a much more ambitious plan for a potential full version bump so for now I'm supporting this behavior with an flag.

I just put out a WIP PR #59 that adds a isZeroNullish option to the component that solves the issue.

[irt-msummers]

I appreciate you looking into it and this fix. I understand. Thanks again

[github-actions]

🎉 This issue has been resolved in version 0.11.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀