-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an example for echo task #1724
Conversation
Signed-off-by: Kevin Su <pingsutw@apache.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion, otherwise LGTM
examples/advanced_composition/advanced_composition/conditional.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com> Signed-off-by: Kevin Su <pingsutw@gmail.com>
blocked by flytekit release |
echo = Echo(name="echo", inputs={"radius": float}) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think outputs
is more straightforward as output values of an echo task
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
related to flyteorg/flytekit#2654