Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Lazy load gRPC plugin #353

Merged
merged 7 commits into from
Jun 5, 2023
Merged

Lazy load gRPC plugin #353

merged 7 commits into from
Jun 5, 2023

Conversation

pingsutw
Copy link
Member

TL;DR

Related to flyteorg/flytepropeller#564

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

NA

Follow-up issue

NA

Signed-off-by: Kevin Su <pingsutw@apache.org>
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #353 (1ece170) into master (9a2bbba) will increase coverage by 1.41%.
The diff coverage is 78.94%.

❗ Current head 1ece170 differs from pull request most recent head 44e29a6. Consider uploading reports for the commit 44e29a6 to get more accurate results

@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
+ Coverage   62.77%   64.19%   +1.41%     
==========================================
  Files         148      148              
  Lines       12664    10286    -2378     
==========================================
- Hits         7950     6603    -1347     
+ Misses       4105     3072    -1033     
- Partials      609      611       +2     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/tasks/plugins/webapi/agent/config.go 100.00% <ø> (ø)
go/tasks/plugins/k8s/dask/dask.go 85.77% <57.14%> (+1.85%) ⬆️
go/tasks/plugins/webapi/agent/plugin.go 68.22% <66.66%> (ø)
go/tasks/plugins/k8s/ray/ray.go 77.48% <84.09%> (-0.09%) ⬇️
...tasks/pluginmachinery/flytek8s/container_helper.go 86.36% <88.88%> (+0.36%) ⬆️
go/tasks/pluginmachinery/flytek8s/pod_helper.go 69.81% <100.00%> (-3.21%) ⬇️
go/tasks/plugins/array/k8s/executor.go 40.67% <100.00%> (+1.09%) ⬆️

... and 125 files with indirect coverage changes

@pingsutw pingsutw requested a review from hamersaw May 26, 2023 18:22
hamersaw
hamersaw previously approved these changes May 26, 2023
Copy link
Contributor

@hamersaw hamersaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right, this is the cleanest way to handle this.

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
hamersaw
hamersaw previously approved these changes May 30, 2023
@pingsutw pingsutw marked this pull request as draft May 31, 2023 18:25
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw pingsutw marked this pull request as ready for review June 2, 2023 22:28
@@ -8,6 +8,8 @@ import (
"testing"
"time"

"github.com/flyteorg/flyteidl/gen/pb-go/flyteidl/admin"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this to make alphabetical?

Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw pingsutw requested a review from hamersaw June 5, 2023 17:17
@pingsutw pingsutw merged commit 06866ee into master Jun 5, 2023
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
* Lazy load grpc plugin

Signed-off-by: Kevin Su <pingsutw@apache.org>

* rename

Signed-off-by: Kevin Su <pingsutw@apache.org>

* rename

Signed-off-by: Kevin Su <pingsutw@apache.org>

* nit

Signed-off-by: Kevin Su <pingsutw@apache.org>

* rename

Signed-off-by: Kevin Su <pingsutw@apache.org>

* lint

Signed-off-by: Kevin Su <pingsutw@apache.org>

* nit

Signed-off-by: Kevin Su <pingsutw@apache.org>

---------

Signed-off-by: Kevin Su <pingsutw@apache.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants