Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comments in _make_dataclass_serializable #2856

Merged

Conversation

mao3267
Copy link
Contributor

@mao3267 mao3267 commented Oct 24, 2024

Tracking issue

Closes flyteorg/flyte#5905

Why are the changes needed?

Since all Flyte types are now serializable, the current usage of the _make_dataclass_serializable function is unclear and may seem to be no longer necessary. Therefore, we have requested an update to the comments in this function to clarify its purpose.

What changes were proposed in this pull request?

  1. Update the comments under the function _make_dataclass_serializable
  2. Provide example usage on Flyte files and its lifecycle

How was this patch tested?

None

Setup process

gh pr checkout 2856

Screenshots

None

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

None

Docs link

None

Signed-off-by: mao3267 <chenvincent610@gmail.com>
Signed-off-by: mao3267 <chenvincent610@gmail.com>
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.41%. Comparing base (3fc51af) to head (f9b9cba).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2856       +/-   ##
===========================================
+ Coverage   45.53%   79.41%   +33.87%     
===========================================
  Files         196      196               
  Lines       20418    20471       +53     
  Branches     2647     2650        +3     
===========================================
+ Hits         9298    16257     +6959     
+ Misses      10658     3477     -7181     
- Partials      462      737      +275     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: mao3267 <chenvincent610@gmail.com>
@wild-endeavor wild-endeavor merged commit 1a1ee53 into flyteorg:master Oct 24, 2024
104 checks passed
@mao3267 mao3267 deleted the make_dataclass_serializable_comment branch October 24, 2024 16:53
kumare3 pushed a commit that referenced this pull request Nov 8, 2024
Signed-off-by: mao3267 <chenvincent610@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flytekit] Request detailed explaination for _make_dataclass_serializable function
2 participants