Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock addPyFile in spark test #2770

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Mock addPyFile in spark test #2770

merged 4 commits into from
Sep 27, 2024

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Sep 26, 2024

Tracking issue

NA

Why are the changes needed?

To fix the spark unit test

What changes were proposed in this pull request?

Mock addPyFile since the CI machine doesn't seem to have enough disk space
related issue: https://stackoverflow.com/a/25707870/9574775

How was this patch tested?

unit test

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

NA

Docs link

NA

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw pingsutw changed the title Mock archive creation in spark test Mock addPyFile in spark test Sep 26, 2024
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.85%. Comparing base (7862ea2) to head (544d65d).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2770       +/-   ##
===========================================
+ Coverage   72.49%   83.85%   +11.35%     
===========================================
  Files         194        3      -191     
  Lines       19872      161    -19711     
  Branches     3921        0     -3921     
===========================================
- Hits        14406      135    -14271     
+ Misses       4768       26     -4742     
+ Partials      698        0      -698     
Flag Coverage Δ
83.85% <ø> (+11.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit 2cf20a4 into master Sep 27, 2024
106 checks passed
otarabai pushed a commit to otarabai/flytekit that referenced this pull request Oct 15, 2024
Signed-off-by: Kevin Su <pingsutw@apache.org>
kumare3 pushed a commit that referenced this pull request Nov 8, 2024
Signed-off-by: Kevin Su <pingsutw@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants