[flyteagent] All agents return dict instead of literal map #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Future-Outlier
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla and
thomasjpfan
as code owners
thomasjpfan
approved these changes
Sep 22, 2024
| @@ -90,7 +90,7 @@ def __init__(self): | |||
| resource = agent.get(metadata) | |||
| assert resource.phase == TaskExecution.SUCCEEDED | |||
| assert ( | |||
| resource.outputs.literals["results"].scalar.structured_dataset.uri | |||
| resource.outputs["results"].uri | |||
There was a problem hiding this comment.
Technically, if there is another library that depends on resource.outputs.literals being defined, then this breaks backward compatibility.
I do not think there are anyone that depends on this, so I am okay with this change.
There was a problem hiding this comment.
Thank you so much for thinking so carefully
kumare3
pushed a commit
that referenced
this pull request
Nov 8, 2024
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#3936
Why are the changes needed?
When users trace the code, they tend to follow patterns we use in Flytekit's agent. By allowing them to use
dictinstead ofLiteralMap, we can improve their development experience. This way, they don't need to understand the details of howLiteralMapworks or what a literal is.What changes were proposed in this pull request?
In the agent's
getrequest:Before:
LiteralMap.After:
dict.Note: We will automatically handle the conversion from
dicttoLiteralMapfor the user.flytekit base_agent.py
flytekit agent_service.py
How was this patch tested?
Through unit tests.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link