add resources to input downloader in the ollama plugin #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
samhita-alla
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
thomasjpfan and
Future-Outlier
as code owners
eapolinario
reviewed
Sep 17, 2024
plugins/flytekit-inference/flytekitplugins/inference/sidecar_template.py
Outdated
Show resolved
Hide resolved
plugins/flytekit-inference/flytekitplugins/inference/sidecar_template.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2754 +/- ##
============================================
- Coverage 100.00% 74.60% -25.40%
============================================
Files 5 194 +189
Lines 122 19762 +19640
Branches 0 4121 +4121
============================================
+ Hits 122 14744 +14622
- Misses 0 4296 +4296
- Partials 0 722 +722 ☔ View full report in Codecov by Sentry. |
thomasjpfan
reviewed
Sep 17, 2024
plugins/flytekit-inference/flytekitplugins/inference/ollama/serve.py
Outdated
Show resolved
Hide resolved
| @@ -138,6 +140,16 @@ def __init__( | |||
| V1VolumeMount(name="shared-data", mount_path="/shared"), | |||
| V1VolumeMount(name="tmp", mount_path="/tmp"), | |||
| ], | |||
| resources=V1ResourceRequirements( | |||
| requests={ | |||
| "cpu": 1, | |||
There was a problem hiding this comment.
I can see the need for setting the CPU as well. From my testing, downloads are usually faster if you give it more than one CPU.
There was a problem hiding this comment.
i made it configurable.
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
@thomasjpfan it worked on the local flyte cluster. i haven't tested it on the demo cluster earlier because i needed to deploy a backend change to test it. |
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
eapolinario
approved these changes
Sep 18, 2024
thomasjpfan
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
To prevent this error from occurring:
failed quota: project-quota: must specify limits.cpu for: input-downloader; limits.memory for: input-downloadererror.What changes were proposed in this pull request?
This PR adds resources to the input downloader init container, without which it results in
failed quota: project-quota: must specify limits.cpu for: input-downloader; limits.memory for: input-downloadererror.How was this patch tested?
On a prod cluster.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link