fix: Calculate the tag based on the name of the base image

[pingsutw]

Tracking issue

NA

Why are the changes needed?

If the base image is an ImageSpec, the flytekit image builder pushes the image to an unexpected place because the tag is not calculated based on the image spec's name.

What changes were proposed in this pull request?

use the name of base ImageSpec to calculate the tag.

How was this patch tested?

Setup process

from flytekit import task, workflow, ImageSpec

image_sklearn = ImageSpec(
    packages=["scikit-learn"],
    apt_packages=["git"],
    registry="ghcr.io/unionai",
    name="flyte-conformance",
)
image_tensorflow = ImageSpec(
    base_image=image_sklearn,
    packages=["tensorflow"],
    registry="ghcr.io/unionai",
    name="flyte-conformance",
)


@task(container_image=image_sklearn)
def t1(a: int) -> int:
    return a + 2


@task(container_image=image_tensorflow)
def t2(a: int) -> int:
    return a + 2


@workflow
def composition_image_wf(a: int = 3):
    t1(a=a)
    t2(a=a)


if __name__ == "__main__":
    print(f"Running my_wf: {composition_image_wf(a=50)}")

Screenshots

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

NA

Docs link

NA

[pingsutw]

we used image_name before. I accidentally removed it in this PR