Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin duckdb version in plugin #2739

Merged
merged 2 commits into from
Sep 16, 2024
Merged

pin duckdb version in plugin #2739

merged 2 commits into from
Sep 16, 2024

Conversation

dansola
Copy link
Contributor

@dansola dansola commented Sep 9, 2024

Why are the changes needed?

Motherduck required duckdb v1.0.0 to work. Without pinning it we can install duckdb 1.1.0 which is incompatible.

What changes were proposed in this pull request?

pin duckdb version in plugin

How was this patch tested?

tested using the plugin after duckdb released 1.1.0

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#2680

Signed-off-by: Daniel Sola <daniel.sola@union.ai>
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.11%. Comparing base (952a17a) to head (f1aaf87).
Report is 4 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (952a17a) and HEAD (f1aaf87). Click for more details.

HEAD has 22 uploads less than BASE
Flag BASE (952a17a) HEAD (f1aaf87)
24 2
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2739      +/-   ##
==========================================
- Coverage   82.04%   72.11%   -9.94%     
==========================================
  Files         288      193      -95     
  Lines       24425    19681    -4744     
  Branches     4097     4100       +3     
==========================================
- Hits        20039    14192    -5847     
- Misses       3681     4781    +1100     
- Partials      705      708       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samhita-alla
Copy link
Contributor

fyi: Today, DuckDB announced DuckDB 1.1.0. We are working to ensure a smooth upgrade with backwards compatibility and will release support for DuckDB 1.1.0 starting September 16, 2024.

Co-authored-by: Kevin Su <pingsutw@apache.org>
@dansola
Copy link
Contributor Author

dansola commented Sep 11, 2024

fyi: Today, DuckDB announced DuckDB 1.1.0. We are working to ensure a smooth upgrade with backwards compatibility and will release support for DuckDB 1.1.0 starting September 16, 2024.

We might need to wait until 1.1.0 supports motherduck. Right now it doesn't.

@dansola dansola merged commit a666246 into master Sep 16, 2024
101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants