Improve error message for entity not found in flytekit cli #2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw
requested review from
wild-endeavor,
kumare3,
eapolinario,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
thomasjpfan
reviewed
Aug 26, 2024
flytekit/exceptions/user.py
Outdated
| self._entity_name = entity_name | ||
|
|
||
| def __str__(self): | ||
| return f"Entity '{self._entity_name}' not found in module '{self._module_name}'" |
There was a problem hiding this comment.
For a new flyte user, I do not think we explain what an "entity" is. I'm looking over the docs and it's hard to find a definition.
There was a problem hiding this comment.
how about "task" or "workflow"?
There was a problem hiding this comment.
"Task/Workflow '{self._entity_name}' not found in module"
Signed-off-by: Kevin Su <pingsutw@apache.org>
eapolinario
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
error message is not clear for users
What changes were proposed in this pull request?
Improve error message for entity not found in flytekit cli
How was this patch tested?
Setup process
Screenshots
Before:
After:
Check all the applicable boxes
Related PRs
NA
Docs link
NA