Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logger.debug when numpy is not found #2712

Conversation

thomasjpfan
Copy link
Member

Why are the changes needed?

Given that NumPy is not a dependency for flytekit, this warning will always show up with the default flytekit install.

What changes were proposed in this pull request?

This PR changes the logger to use debug instead.

Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.94%. Comparing base (83b90fa) to head (ade0b93).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2712       +/-   ##
===========================================
+ Coverage   78.69%   97.94%   +19.24%     
===========================================
  Files         187       15      -172     
  Lines       19257      438    -18819     
  Branches     4029        0     -4029     
===========================================
- Hits        15155      429    -14726     
+ Misses       3404        9     -3395     
+ Partials      698        0      -698     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wild-endeavor wild-endeavor enabled auto-merge (squash) August 26, 2024 18:11
@wild-endeavor wild-endeavor merged commit f155140 into flyteorg:master Aug 26, 2024
100 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants