Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prerelease flag with uv in image builder #2697

Merged

Conversation

thomasjpfan
Copy link
Member

Why are the changes needed?

Using the prerelease flag will instead prerelease versions by default, which is unexpected. If users want to use prerelease builds they can set ImageSpec(env=dict(UV_PRERELEASE="allow")).

What changes were proposed in this pull request?

This PR removes the option.

How was this patch tested?

I ran image builder with this change.

Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
@thomasjpfan thomasjpfan changed the title Remove prerelease flag with uv Remove prerelease flag with uv in image builder Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.63%. Comparing base (a8f68d7) to head (99f7fd2).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2697       +/-   ##
===========================================
+ Coverage   78.91%   93.63%   +14.71%     
===========================================
  Files         316       78      -238     
  Lines       24965     3832    -21133     
  Branches     4012        0     -4012     
===========================================
- Hits        19702     3588    -16114     
+ Misses       4548      244     -4304     
+ Partials      715        0      -715     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomasjpfan thomasjpfan merged commit 10b5460 into flyteorg:master Aug 21, 2024
98 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants