[Error Message] Dataclasses Mismatched Type #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Future-Outlier
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla and
thomasjpfan
as code owners
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Future-Outlier
changed the title
Future-Outlier
changed the title
pingsutw
approved these changes
Aug 6, 2024
Future-Outlier
added a commit
that referenced
this pull request
Aug 6, 2024
* Show different of types in dataclass when transforming error Signed-off-by: Future-Outlier <eric901201@gmail.com> * add tests for dataclass Signed-off-by: Future-Outlier <eric901201@gmail.com> * fix tests Signed-off-by: Future-Outlier <eric901201@gmail.com> --------- Signed-off-by: Future-Outlier <eric901201@gmail.com>
mao3267
pushed a commit
to mao3267/flytekit
that referenced
this pull request
Aug 9, 2024
* Show different of types in dataclass when transforming error Signed-off-by: Future-Outlier <eric901201@gmail.com> * add tests for dataclass Signed-off-by: Future-Outlier <eric901201@gmail.com> * fix tests Signed-off-by: Future-Outlier <eric901201@gmail.com> --------- Signed-off-by: Future-Outlier <eric901201@gmail.com> Signed-off-by: mao3267 <chenvincent610@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
The error message is not clear for dataclasses output.
What changes were proposed in this pull request?
print actual output type and expected output type.
How was this patch tested?
local execution, remote execution and unit tests.
Screenshots
Before
After
Check all the applicable boxes
Related PRs
Docs link