-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update error message for TypeTransformerFailedError #2648
Update error message for TypeTransformerFailedError #2648
Conversation
Signed-off-by: wayner0628 <a901639@gmail.com>
Signed-off-by: wayner0628 <a901639@gmail.com>
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Signed-off-by: wayner0628 <a901639@gmail.com>
Fixed the check fail where |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2648 +/- ##
===========================================
- Coverage 78.77% 54.83% -23.94%
===========================================
Files 187 236 +49
Lines 19149 21554 +2405
Branches 3993 3781 -212
===========================================
- Hits 15085 11820 -3265
- Misses 3374 9224 +5850
+ Partials 690 510 -180 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kevin Su <pingsutw@apache.org>
Congrats on merging your first pull request! 🎉 |
Signed-off-by: wayner0628 <a901639@gmail.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: wayner0628 <a901639@gmail.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Kevin Su <pingsutw@apache.org> Signed-off-by: mao3267 <chenvincent610@gmail.com>
Tracking issue
Related to flyteorg/flyte#5353
Why are the changes needed?
TypeTransformerFailedError
directly and provide clearer feedback on unsupported type transformations instead of internalAttributeError
messages likeAttributeError: 'NoneType' object has no attribute 'string_value'
.What changes were proposed in this pull request?
AttributeError
when a SimpleTransformer receives an incorrect literal format.How was this patch tested?
Executed unit tests using:
Screenshots
Running the above unit test on the master branch:
Running the above unit test on this new branch:
fix-check-simpletransformer-get-union-type-error
-> No additional errors occur.
Check all the applicable boxes
Related PRs
N/A
Docs link
N/A