Fix pandera plugin for 0.20 #2545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
pingsutw
reviewed
Jul 1, 2024
| @@ -7,7 +7,7 @@ | |||
|
|
|||
|
|
|||
| def test_pandera_dataframe_type_hints(): | |||
| class InSchema(pandera.SchemaModel): | |||
| class InSchema(pandera.DataFrameModel): | |||
There was a problem hiding this comment.
Should we set a lower bound in the setup.py?
pingsutw
approved these changes
Jul 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2545 +/- ##
===========================================
- Coverage 84.74% 55.81% -28.93%
===========================================
Files 315 226 -89
Lines 24142 21093 -3049
Branches 3666 3681 +15
===========================================
- Hits 20458 11774 -8684
- Misses 3025 8830 +5805
+ Partials 659 489 -170 ☔ View full report in Codecov by Sentry. |
bgedik
pushed a commit
to bgedik/flytekit
that referenced
this pull request
Jul 3, 2024
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> Signed-off-by: bugra.gedik <bugra.gedik@predera.ai>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> Signed-off-by: Jan Fiedler <jan@union.ai>
mao3267
pushed a commit
to mao3267/flytekit
that referenced
this pull request
Jul 29, 2024
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> Signed-off-by: mao3267 <chenvincent610@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes flyteorg/flyte#999
Why are the changes needed?
Pandera's
SchemaModelAPI was removed in 0.20What changes were proposed in this pull request?
Use the newer
DataFrameModelin tests.