Run flytekit tasks on remote with local default values passed correctly #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```python @task def default_inputs(i: int = 0, f: float = 10.0, e: Color = Color.RED, b: bool = True, j: typing.Optional[int] = None): print(i, f, e, b, j) ``` Running this on remote will now work correctly ```bash pyflyte run --remote exhaustive.py default_inputs ``` Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
kumare3
requested review from
wild-endeavor,
eapolinario,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
pingsutw
approved these changes
Jun 24, 2024
bgedik
pushed a commit
to bgedik/flytekit
that referenced
this pull request
Jul 3, 2024
…ly (flyteorg#2525) * Run flytekit tasks on remote with local default values passed correctly ```python @task def default_inputs(i: int = 0, f: float = 10.0, e: Color = Color.RED, b: bool = True, j: typing.Optional[int] = None): print(i, f, e, b, j) ``` Running this on remote will now work correctly ```bash pyflyte run --remote exhaustive.py default_inputs ``` Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> * fixing lint Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> --------- Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> Co-authored-by: Ketan Umare <kumare3@users.noreply.github.com> Signed-off-by: bugra.gedik <bugra.gedik@predera.ai>
3 tasks
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
…ly (#2525) * Run flytekit tasks on remote with local default values passed correctly ```python @task def default_inputs(i: int = 0, f: float = 10.0, e: Color = Color.RED, b: bool = True, j: typing.Optional[int] = None): print(i, f, e, b, j) ``` Running this on remote will now work correctly ```bash pyflyte run --remote exhaustive.py default_inputs ``` Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> * fixing lint Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> --------- Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> Co-authored-by: Ketan Umare <kumare3@users.noreply.github.com> Signed-off-by: Jan Fiedler <jan@union.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running this on remote will now work correctly
Tracking issue
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link