Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove upper bound of plugin dependencies for flytekit-polars #2514

Merged
merged 8 commits into from
Aug 23, 2024

Conversation

Mecoli1219
Copy link
Contributor

@Mecoli1219 Mecoli1219 commented Jun 19, 2024

Tracking issue

Why are the changes needed?

  1. polars.DataFrame.describe() is not recommended to be used programmatically as suggested by Polars's official documentation, causing the behavior difference in different polars version.
  2. frame_equal() is renamed to equals() in version 0.19.16

What changes were proposed in this pull request?

  1. Use to_pandas() directly.
  2. I changed it into another testing function polars.testing.assert_frame_equal.

How was this patch tested?

Setup process

Screenshots

image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.76%. Comparing base (a8f68d7) to head (dc1940d).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2514      +/-   ##
==========================================
+ Coverage   78.91%   83.76%   +4.84%     
==========================================
  Files         316        3     -313     
  Lines       24965      154   -24811     
  Branches     4012        0    -4012     
==========================================
- Hits        19702      129   -19573     
+ Misses       4548       25    -4523     
+ Partials      715        0     -715     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mecoli1219 Mecoli1219 changed the title remove upper bound of plugin dependencies for flytekit-polars [wip] remove upper bound of plugin dependencies for flytekit-polars Jul 15, 2024
@Mecoli1219 Mecoli1219 marked this pull request as draft July 15, 2024 01:23
Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
@Mecoli1219 Mecoli1219 changed the title [wip] remove upper bound of plugin dependencies for flytekit-polars remove upper bound of plugin dependencies for flytekit-polars Aug 22, 2024
@Mecoli1219 Mecoli1219 marked this pull request as ready for review August 22, 2024 03:36
Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@pingsutw pingsutw merged commit be574dd into flyteorg:master Aug 23, 2024
97 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants