-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove upper bound of plugin dependencies for flytekit-polars #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mecoli1219
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
June 19, 2024 15:17
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2514 +/- ##
==========================================
+ Coverage 78.91% 83.76% +4.84%
==========================================
Files 316 3 -313
Lines 24965 154 -24811
Branches 4012 0 -4012
==========================================
- Hits 19702 129 -19573
+ Misses 4548 25 -4523
+ Partials 715 0 -715 ☔ View full report in Codecov by Sentry. |
Mecoli1219
changed the title
remove upper bound of plugin dependencies for flytekit-polars
[wip] remove upper bound of plugin dependencies for flytekit-polars
Jul 15, 2024
Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
Mecoli1219
changed the title
[wip] remove upper bound of plugin dependencies for flytekit-polars
remove upper bound of plugin dependencies for flytekit-polars
Aug 22, 2024
Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
pingsutw
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
polars.DataFrame.describe()
is not recommended to be used programmatically as suggested by Polars's official documentation, causing the behavior difference in differentpolars
version.frame_equal()
is renamed toequals()
in version 0.19.16What changes were proposed in this pull request?
to_pandas()
directly.How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link