fix: Prevent local files from being moved when using FlyteFile on local executions

[ggydush]

Tracking issue

N/A

Why are the changes needed?

When running local executions, local files that exist should not need to be copied. When running large files, this can become a bottleneck.

What changes were proposed in this pull request?

Check if running a local task execution when converting FlyteFile to literal.

How was this patch tested?

from flytekit import task
from flytekit.types.file import FlyteFile


@task
def example(ff: FlyteFile) -> str:
    downloaded_path = ff.download()
    print(downloaded_path)
    return str(ff.path)


example(ff=__file__)

Before the fix, this printed:

/var/folders/d1/n1tj86t11pj_drgfg7_br5n00000gn/T/flyte-qd4bk3t0/raw/0fee47924014b3cb5f12295a48330c0f/tmp.py

After the fix, this printed:

/Users/ggydush/dev/delve/flytekit/flytekit/types/file/tmp.py

Setup process

Screenshots

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

Docs link

[eapolinario]

Thanks for the PR, @ggydush . This is a great idea IMO. Can you take a look at the test failures?

[ggydush]

Thanks for the PR, @ggydush . This is a great idea IMO. Can you take a look at the test failures?

Yep fixed! Looks like there's still issue with lint/mac builds but doesn't seem related.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 50.68%. Comparing base (647b071) to head (9e2510c).
Report is 1 commits behind head on master.

❗ Current head 9e2510c differs from pull request most recent head 078a47d

Please upload reports for the commit 078a47d to get more accurate results.

Files	Patch %	Lines
flytekit/types/file/file.py	0.00%	4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (647b071) and HEAD (9e2510c). Click for more details.

HEAD has 14 uploads less than BASE

| Flag | BASE (647b071) | HEAD (9e2510c) | |------|------|------| ||15|1|

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #2476       +/-   ##
===========================================
- Coverage   91.30%   50.68%   -40.63%     
===========================================
  Files          78      182      +104     
  Lines        3968    18508    +14540     
  Branches        0     3642     +3642     
===========================================
+ Hits         3623     9380     +5757     
- Misses        345     8650     +8305     
- Partials        0      478      +478     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.