Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeTransformer] Support non-Any Python types as Any input in workflows #2432

Closed
wants to merge 18 commits into from
Closed

[TypeTransformer] Support non-Any Python types as Any input in workflows #2432

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f0963e1
[TypeTransformer] support input Non-Any Any Type
Future-Outlier May 20, 2024
449a1c7
lint
Future-Outlier May 20, 2024
f95109c
pretty version
Future-Outlier May 22, 2024
dc49973
fix-test
Future-Outlier May 22, 2024
33ca344
support any and non any workflow
Future-Outlier May 22, 2024
0b6a8b3
use metadata [str, Any
Future-Outlier May 24, 2024
8988464
use try except
Future-Outlier May 24, 2024
c6eda1d
add print
Future-Outlier May 25, 2024
4733f0b
add test
Future-Outlier May 25, 2024
c9983a3
use pydoc to work in local execution
Future-Outlier May 28, 2024
0ac6686
python dotted path
Future-Outlier May 28, 2024
1452650
support dataclass decorator input from command line
Future-Outlier May 28, 2024
ea65394
add annotations
Future-Outlier May 28, 2024
8aa1b86
try except List[int]
Future-Outlier May 29, 2024
29bd9d4
use any simple type
Future-Outlier Jun 4, 2024
31d60cc
fix hugging face plugin
Future-Outlier Jun 4, 2024
5020e24
add pingsu's note
Future-Outlier Jun 5, 2024
3f179fc
add notes with pingsutw
Future-Outlier Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint 
Signed-off-by: Future-Outlier <eric901201@gmail.com>
  • Loading branch information
@Future-Outlier
Future-Outlier committed May 25, 2024
commit 449a1c74559db79ac1dc9ef58ad27a658d62b9c1
7 changes: 2 additions & 5 deletions flytekit/types/pickle/pickle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ def to_python_value(self, ctx: FlyteContext, lv: Literal, expected_python_type:
return FlytePickle.from_pickle(uri)
except Exception as e:
from datetime import datetime, timedelta

if lv.scalar:
if lv.scalar.primitive:
if lv.scalar.primitive.integer:
Expand All @@ -107,11 +108,7 @@ def to_python_value(self, ctx: FlyteContext, lv: Literal, expected_python_type:
return TypeEngine.to_python_value(ctx, lv, datetime)
elif lv.scalar.primitive.duration:
return TypeEngine.to_python_value(ctx, lv, timedelta)
return None
print("expected_python_type: ", expected_python_type)
print(f"Failed to convert value from pickle {e}")
# return None
return TypeEngine.to_python_value(ctx, lv, int)
raise e

def to_literal(self, ctx: FlyteContext, python_val: T, python_type: Type[T], expected: LiteralType) -> Literal:
if python_val is None:
Expand Down