Move SageMakerEndpointMetadata to agent.py #2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <pingsutw@gmail.com>
pingsutw
requested review from
wild-endeavor,
kumare3,
eapolinario and
cosmicBboy
as code owners
dosubot
bot
added
the
size:M
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2310 +/- ##
==========================================
- Coverage 83.48% 83.48% -0.01%
==========================================
Files 324 324
Lines 24717 24723 +6
Branches 3517 3517
==========================================
+ Hits 20634 20639 +5
- Misses 3450 3452 +2
+ Partials 633 632 -1 ☔ View full report in Codecov by Sentry. |
samhita-alla
previously approved these changes
Mar 29, 2024
plugins/flytekit-aws-sagemaker/flytekitplugins/awssagemaker_inference/task.py
Outdated
Show resolved
Hide resolved
pingsutw
changed the title
samhita-alla
approved these changes
Mar 29, 2024
wild-endeavor
approved these changes
Mar 29, 2024
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Kevin Su <pingsutw@gmail.com> Signed-off-by: Jan Fiedler <jan@union.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#3936
Why are the changes needed?
agent failed to encode the metadata
What changes were proposed in this pull request?
Move SageMakerEndpointMetadata to agent.py and override encode()/decode() method
How was this patch tested?
Remote
Setup process
Screenshots
Check all the applicable boxes
Related PRs
NA
Docs link
NA