remove ray task post_execute because ray.shutdown will be automatically called #2304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
ray.shutdown()
will always be automatically called (registered throughatexit
here). We should rather rely on it instead of explicitly calling it again especially we don't set_exiting_interpreter=True
which may result in disconnecting too soon before worker logs are flushed to driver.What changes were proposed in this pull request?
remove the
post_execute
of ray taskHow was this patch tested?
test with a simple example:
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link