This repository has been archived by the owner on May 31, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Remove redundant YAML packages:
github.com/ghodss/yaml
andgopkg.in/yaml.v2
Type
Are all requirements met?
Complete description
Currently four YAML packages are used:
github.com/ghodss/yaml
gopkg.in/yaml.v2
gopkg.in/yaml.v3
sigs.k8s.io/yaml
We can keep only two of them:
gopkg.in/yaml.v3
sigs.k8s.io/yaml
The package
github.com/ghodss/yaml
is no longer actively maintained. See discussion in ghodss/yaml#80 and ghodss/yaml#75.sigs.k8s.io/yaml
is a permanent fork ofghodss/yaml
and is actively maintained by Kubernetes SIG, also widely used in K8s projects.We are only using
gopkg.in/yaml.v2
incmd/config/subcommand/project/project_config.go
. Switching togopkg.in/yaml.v3
doesn't introduce breaking change here.Tracking Issue
Follow-up issue
NA