Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Bug fix in sandbix start #161

Merged
merged 5 commits into from
Aug 19, 2021
Merged

Bug fix in sandbix start #161

merged 5 commits into from
Aug 19, 2021

Conversation

yindia
Copy link
Contributor

@yindia yindia commented Aug 19, 2021

TL;DR

  • Updated boilerplate
  • Small bug fix in version compare until (Currently we have a condition that checks greater then equal but now we only check GreateThen.....This bug exist in version compare)
  • Because we are mounting container file in localhost system that's why we are not able to change the permission of the file, But now we created a empty file and we only overwrite while mounting docker volume

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

yindia added 2 commits August 18, 2021 21:49
Signed-off-by: Yuvraj <code@evalsocket.dev>
Signed-off-by: Yuvraj <code@evalsocket.dev>
@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #161 (46fcd1f) into master (ce1c5f4) will increase coverage by 8.49%.
The diff coverage is 79.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
+ Coverage   76.17%   84.67%   +8.49%     
==========================================
  Files         106       90      -16     
  Lines        2695     3106     +411     
==========================================
+ Hits         2053     2630     +577     
+ Misses        528      305     -223     
- Partials      114      171      +57     
Impacted Files Coverage Δ
cmd/config/config.go 66.66% <ø> (ø)
cmd/get/project.go 86.36% <ø> (+3.03%) ⬆️
cmd/register/files.go 87.09% <ø> (+1.38%) ⬆️
cmd/sandbox/teardown.go 75.00% <0.00%> (-10.72%) ⬇️
cmd/update/named_entity.go 100.00% <ø> (ø)
pkg/adminutils/config.go 0.00% <ø> (-100.00%) ⬇️
pkg/ext/fetcher.go 100.00% <ø> (ø)
cmd/root.go 44.82% <54.54%> (ø)
cmd/get/execution_util.go 61.90% <61.53%> (+6.54%) ⬆️
pkg/k8s/k8s.go 63.63% <63.63%> (ø)
... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fd7282...46fcd1f. Read the comment docs.

@yindia yindia marked this pull request as draft August 19, 2021 04:07
Signed-off-by: Yuvraj <code@evalsocket.dev>
@yindia yindia marked this pull request as ready for review August 19, 2021 08:43
Signed-off-by: Yuvraj <code@evalsocket.dev>
pkg/util/util.go Show resolved Hide resolved
cmd/sandbox/start.go Show resolved Hide resolved
Signed-off-by: Yuvraj <code@evalsocket.dev>
@yindia yindia merged commit 8acc569 into master Aug 19, 2021
@yindia yindia deleted the hotfix/upgrade branch August 19, 2021 09:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants