This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Swap base64 for 32 encoding when constructing s3 key#406
Merged
wild-endeavor merged 2 commits intomasterfrom Apr 14, 2022
Merged
Swap base64 for 32 encoding when constructing s3 key#406wild-endeavor merged 2 commits intomasterfrom
wild-endeavor merged 2 commits intomasterfrom
Conversation
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
wild-endeavor
requested review from
EngHabu,
anandswaminathan,
katrogan and
kumare3
as code owners
wild-endeavor
changed the title
EngHabu
previously approved these changes
Apr 14, 2022
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
==========================================
- Coverage 61.05% 61.04% -0.01%
==========================================
Files 154 154
Lines 11081 11082 +1
==========================================
Hits 6765 6765
- Misses 3608 3609 +1
Partials 708 708
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eapolinario
approved these changes
Apr 14, 2022
alexapdev
pushed a commit
to alexapdev/flyteadmin
that referenced
this pull request
Apr 20, 2022
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Alex Pozimenko <alex.pozimenko@woven-planet.global>
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yee Hing Tong wild-endeavor@users.noreply.github.com
Read then delete this section
- Make sure to use a concise title for the pull-request.
- Use #patch, #minor or #major in the pull-request title to bump the corresponding version. Otherwise, the patch version
will be bumped. More details
TL;DR
Please replace this text with a description of what this PR accomplishes.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/