Added missing metrics for launchplanidkey and phase

[pmahindrakar-oss]

Signed-off-by: Prafulla Mahindrakar prafulla.mahindrakar@gmail.com

TL;DR

Node executions

flyte:admin:admin:node_execution_manager:node_executions_terminated{app_name="",domain="development",exec_id="f2282f588a3b940cd99d",node="end-node",phase="SUCCEEDED",project="flytesnacks",runtime_type="",runtime_version="",task="",tasktype="",wf=""} 1
flyte:admin:admin:node_execution_manager:node_executions_terminated{app_name="",domain="development",exec_id="f2282f588a3b940cd99d",node="n0",phase="SUCCEEDED",project="flytesnacks",runtime_type="",runtime_version="",task="",tasktype="",wf=""} 1
flyte:admin:admin:node_execution_manager:node_executions_terminated{app_name="",domain="development",exec_id="f2282f588a3b940cd99d",node="n1",phase="SUCCEEDED",project="flytesnacks",runtime_type="",runtime_version="",task="",tasktype="",wf=""} 1
flyte:admin:admin:node_execution_manager:node_executions_terminated{app_name="",domain="development",exec_id="f2282f588a3b940cd99d",node="start-node",phase="SUCCEEDED",project="flytesnacks",runtime_type="",runtime_version="",task="",tasktype="",wf=""} 1

Task executions

flyte:admin:admin:task_execution_manager:task_executions_terminated{app_name="",domain="development",exec_id="f2282f588a3b940cd99d",node="n0",phase="SUCCEEDED",project="flytesnacks",runtime_type="",runtime_version="",task="core.control_flow.map_task.mapper_a_mappable_task_0-0",tasktype="",wf=""} 1
flyte:admin:admin:task_execution_manager:task_executions_terminated{app_name="",domain="development",exec_id="f2282f588a3b940cd99d",node="n1",phase="SUCCEEDED",project="flytesnacks",runtime_type="",runtime_version="",task="core.control_flow.map_task.coalesce-0",tasktype="",wf=""} 1

Executions
flyte:admin:admin:execution_manager:executions_terminated{app_name="",domain="development",exec_id="f2282f588a3b940cd99d",node="",phase="SUCCEEDED",project="flytesnacks",runtime_type="",runtime_version="",task="",tasktype="",wf=""} 1

Type

• Bug Fix
• Feature
• Plugin

Are all requirements met?

• Code completed
• Smoke tested
• Unit tests added
• Code documentation added
• Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

[codecov]

Codecov Report

Merging #405 (b305062) into master (3c29b17) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   61.05%   61.10%   +0.05%     
==========================================
  Files         154      154              
  Lines       11081    11081              
==========================================
+ Hits         6765     6771       +6     
+ Misses       3608     3602       -6     
  Partials      708      708              

Flag	Coverage Δ
unittests	60.05% <ø> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...implementations/workflow_execution_event_writer.go	80.00% <0.00%> (+40.00%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c29b17...b305062. Read the comment docs.