Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Allow archiving of task named entities#402

Merged
katrogan merged 2 commits intomasterfrom
archive-task
Apr 12, 2022
Merged

Allow archiving of task named entities#402
katrogan merged 2 commits intomasterfrom
archive-task

Conversation

@katrogan
Copy link
Contributor

Signed-off-by: Katrina Rogan katroganGH@gmail.com

TL;DR

Allow archiving of task named entities

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Needed to unblock console work to support archiving task named entities

Tracking Issue

https://github.com/flyteorg/flyteconsole/issues/321

Follow-up issue

NA

Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
@katrogan
Copy link
Contributor Author

cc @ursucarina

ursucarina
ursucarina previously approved these changes Apr 12, 2022
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #402 (1a1b2bf) into master (3f21a34) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 1a1b2bf differs from pull request most recent head 9cd534b. Consider uploading reports for the commit 9cd534b to get more accurate results

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
+ Coverage   61.06%   61.11%   +0.05%     
==========================================
  Files         154      154              
  Lines       11084    11084              
==========================================
+ Hits         6768     6774       +6     
+ Misses       3608     3602       -6     
  Partials      708      708              
Flag Coverage Δ
unittests 60.06% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../manager/impl/validation/named_entity_validator.go 92.85% <100.00%> (ø)
...implementations/workflow_execution_event_writer.go 80.00% <0.00%> (+40.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f21a34...9cd534b. Read the comment docs.

Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
@katrogan katrogan dismissed stale reviews from ursucarina and pmahindrakar-oss via 9cd534b April 12, 2022 18:00
@katrogan katrogan merged commit 3d092c7 into master Apr 12, 2022
@katrogan katrogan deleted the archive-task branch April 12, 2022 19:01
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants