This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Conversation
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
pmahindrakar-oss
previously approved these changes
Apr 12, 2022
Contributor
Author
|
cc @ursucarina |
ursucarina
previously approved these changes
Apr 12, 2022
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
==========================================
+ Coverage 61.06% 61.11% +0.05%
==========================================
Files 154 154
Lines 11084 11084
==========================================
+ Hits 6768 6774 +6
+ Misses 3608 3602 -6
Partials 708 708
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
9cd534b
ursucarina
approved these changes
Apr 12, 2022
pmahindrakar-oss
approved these changes
Apr 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Katrina Rogan katroganGH@gmail.com
TL;DR
Allow archiving of task named entities
Type
Are all requirements met?
Complete description
Needed to unblock console work to support archiving task named entities
Tracking Issue
https://github.com/flyteorg/flyteconsole/issues/321
Follow-up issue
NA