This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Getting security context from the resolved execution parameters#401
Merged
pmahindrakar-oss merged 4 commits intomasterfrom Apr 12, 2022
Merged
Getting security context from the resolved execution parameters#401pmahindrakar-oss merged 4 commits intomasterfrom
pmahindrakar-oss merged 4 commits intomasterfrom
Conversation
pmahindrakar-oss
requested review from
EngHabu,
anandswaminathan,
katrogan,
kumare3 and
wild-endeavor
as code owners
EngHabu
previously approved these changes
Apr 12, 2022
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
pmahindrakar-oss
force-pushed
the
pmahindrakar/test-security-context
branch
from
35c25b4 to
4a029e2
Compare
Codecov Report
@@ Coverage Diff @@
## master #401 +/- ##
==========================================
- Coverage 61.14% 61.12% -0.03%
==========================================
Files 154 154
Lines 11116 11114 -2
==========================================
- Hits 6797 6793 -4
- Misses 3611 3612 +1
- Partials 708 709 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
yindia
approved these changes
Apr 12, 2022
pingsutw
approved these changes
Apr 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prafulla Mahindrakar prafulla.mahindrakar@gmail.com
TL;DR
Removed the resolved security context function and always use the security context from the execution parameters which go through the resolution from request, launchplan, matchable attribute and application configuration
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/