This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Merged
Conversation
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
EngHabu
commented
Apr 7, 2022
pkg/config/config.go
Outdated
|
|
||
| DataProxy DataProxyConfig `json:"dataProxy" pflag:",Defines data proxy configuration."` | ||
|
|
||
| ExportedDNS config.URL `json:"exportedDNS" pflag:",Defines the http endpoint the service is accessible at."` |
Contributor
Author
There was a problem hiding this comment.
What should I call this 😬, @wild-endeavor ?
Contributor
There was a problem hiding this comment.
Can we add a comment to explain under what circumstance this should be used?
Codecov Report
@@ Coverage Diff @@
## master #392 +/- ##
==========================================
- Coverage 61.11% 61.08% -0.04%
==========================================
Files 154 154
Lines 11107 11113 +6
==========================================
Hits 6788 6788
- Misses 3611 3617 +6
Partials 708 708
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
katrogan
reviewed
Apr 9, 2022
pkg/server/service.go
Outdated
|
|
||
| configuration := runtime2.NewConfigurationProvider() | ||
| service.RegisterAdminServiceServer(grpcServer, adminservice.NewAdminServer(ctx, pluginRegistry, configuration, cfg.KubeConfig, cfg.Master, dataStorageClient, scope.NewSubScope("admin"))) | ||
| service.RegisterAuthMetadataServiceServer(grpcServer, authCtx.AuthMetadataService()) |
Contributor
There was a problem hiding this comment.
how does this work if UseAuth isn't true?
katrogan
previously approved these changes
Apr 9, 2022
kumare3
previously approved these changes
Apr 10, 2022
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
katrogan
pushed a commit
that referenced
this pull request
Apr 12, 2022
This reverts commit f04414e.
katrogan
pushed a commit
that referenced
this pull request
Apr 12, 2022
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Always register the metadata endpoint Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Rename Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Using released flyteidl Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * lint Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Initialize authz metadata server Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Haytham Abuelfutuh haytham@afutuh.com
TL;DR
Expose a new property in Public Client metadata and always registers the metadata endpoint (even when auth is not configured)
Type
Tracking Issue
fixes https://github.com/flyteorg/flyte/issues/