Support flag in ray plugin config to optionally disable ingress for Ray cluster#6905
Merged
EngHabu merged 2 commits intoflyteorg:masterfrom Feb 9, 2026
Conversation
Signed-off-by: mickjermsurawong <mickjermsurawong@openai.com>
mickjermsurawong-openai
force-pushed
the
dev/mickj-support-disable-ingress
branch
from
88e8d13 to
58dda2d
Compare
EngHabu
reviewed
Feb 9, 2026
| TTLSecondsAfterFinished: 3600, | ||
| ServiceType: "NodePort", | ||
| IncludeDashboard: true, | ||
| EnableIngress: true, |
Contributor
There was a problem hiding this comment.
I like booleans to default to false... So I think this should be DisableIngress
Contributor
Author
There was a problem hiding this comment.
Addressed thank you for fast response!
Signed-off-by: mickjermsurawong <mickjermsurawong@openai.com>
mickjermsurawong-openai
force-pushed
the
dev/mickj-support-disable-ingress
branch
from
91ee01c to
fbfd6b8
Compare
EngHabu
approved these changes
Feb 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6905 +/- ##
=======================================
Coverage 56.95% 56.95%
=======================================
Files 929 929
Lines 58151 58152 +1
=======================================
+ Hits 33120 33121 +1
Misses 21989 21989
Partials 3042 3042
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Congrats on merging your first pull request! 🎉 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Labels
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link