[WIP][Flyteadmin] Add variablemap in dataproxy for dataclass/pydantic #6136
+1,053
−635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Problem
There are two main components to manage when retrieving the
variable_map
in the Dataproxy'sGetData
function:GetDataFromNodeExecution
andGetDataFromTaskExecution
. Since thevariable_map
resides in theTaskClosure
, it is logical to retrieve it from the Task Repository using the Task's identification details (ID, project, domain, and version).However, I am unable to determine how to access the output from node execution. Is there a way to retrieve the
TaskClosure
(orTask
) directly from theNodeExecution
?Tracking issue
#6081
Why are the changes needed?
While the task input/output is represented as a dataclass or Pydantic model, using the get function to fetch the FlyteRemote execution output will fail due to the absence of the variable_map information. To address this issue, we aim to provide the input/output variable_map through the Dataproxy as a solution.
What changes were proposed in this pull request?
GetData
from dataproxy service.How was this patch tested?
TODO
Setup process
Screenshots
TODO
Check all the applicable boxes
Related PRs
flyteorg/flytekit#3031
Docs link
TODO