Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch agent metadata service dynamically #5392

Closed
wants to merge 18 commits into from
Closed

Conversation

Future-Outlier
Copy link
Member

Tracking issue

#3936

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

pingsutw and others added 13 commits March 5, 2024 17:51
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
@Future-Outlier Future-Outlier changed the title Watch agent metadata service v2 [WIP] Watch agent metadata service v2 May 19, 2024
@Future-Outlier Future-Outlier marked this pull request as draft May 19, 2024 04:12
Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 24.13793% with 44 lines in your changes missing coverage. Please review.

Project coverage is 62.29%. Comparing base (25c3596) to head (992c3ab).
Report is 138 commits behind head on master.

Files with missing lines Patch % Lines
...yteplugins/go/tasks/plugins/webapi/agent/plugin.go 13.51% 32 Missing ⚠️
...yteplugins/go/tasks/plugins/webapi/agent/client.go 42.85% 10 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5392      +/-   ##
==========================================
+ Coverage   61.07%   62.29%   +1.22%     
==========================================
  Files         793      610     -183     
  Lines       51226    37574   -13652     
==========================================
- Hits        31288    23408    -7880     
+ Misses      17062    12035    -5027     
+ Partials     2876     2131     -745     
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.66% <ø> (-0.25%) ⬇️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 67.97% <ø> (ø)
unittests-flyteidl 79.04% <ø> (ø)
unittests-flyteplugins 61.75% <24.13%> (-0.20%) ⬇️
unittests-flytepropeller ?
unittests-flytestdlib 65.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
@Future-Outlier Future-Outlier changed the title [WIP] Watch agent metadata service v2 [WIP] Watch agent metadata service dynamically Jun 8, 2024
Signed-off-by: Future-Outlier <eric901201@gmail.com>
@Future-Outlier Future-Outlier changed the title [WIP] Watch agent metadata service dynamically Watch agent metadata service dynamically Jun 8, 2024
@Future-Outlier Future-Outlier marked this pull request as ready for review June 8, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants