Fix flaky test_monitor (#4537)

* Fix flaky test_monitor Signed-off-by: Kevin Su <pingsutw@apache.org> * fix test Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com>
flyteorg · Dec 6, 2023 · b9907f4 · b9907f4
1 parent 2553153
commit b9907f4
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/flyteplugins/go/tasks/pluginmachinery/internal/webapi/monitor_test.go b/flyteplugins/go/tasks/pluginmachinery/internal/webapi/monitor_test.go
@@ -21,6 +21,7 @@ import (
 
 func Test_monitor(t *testing.T) {
 	ctx := context.Background()
+	ctx, cancel := context.WithCancel(ctx)
 	tCtx := &mocks.TaskExecutionContext{}
 	ctxMeta := &mocks.TaskExecutionMetadata{}
 	execID := &mocks.TaskExecutionID{}
@@ -70,6 +71,7 @@ func Test_monitor(t *testing.T) {
 
 	// Wait for sync to run to actually delete the resource
 	wg.Wait()
+	cancel()
 	cachedItem, err = cacheObj.GetOrCreate("generated_name", CacheItem{Resource: "new_resource"})
 	assert.NoError(t, err)
 	assert.Equal(t, "new_resource", cachedItem.(CacheItem).Resource.(string))