Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add count, remove functionality to systems #1

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Add count, remove functionality to systems #1

merged 1 commit into from
Aug 20, 2024

Conversation

StephenBrown2
Copy link
Contributor

This adds a couple flags to systems: --count and --lastCheckinBefore, which will show a plain count of systems filtered, and allow filtering by lastCheckin date, respectively.

It also adds the ability to unregister/remove systems, provided the same filtering abilities as with listing systems.

@flynshue
Copy link
Owner

I totally forgot this exists. Thanks for the updates 😄

@flynshue flynshue merged commit 92c9437 into flynshue:main Aug 20, 2024
@flynshue
Copy link
Owner

@StephenBrown2 I haven't used this in a long time, would you be interested in adding some tests? I really should have added them for the start but got busy :( and should have added GHA + goreleaser to make the binaries

@StephenBrown2
Copy link
Contributor Author

Thanks for the merge!
Sadly, I probably don't have time for tests right now, though of course they are often helpful. If I find myself adding more to it, I'll try to add tests at that point.

@StephenBrown2 StephenBrown2 deleted the systems-count-and-remove branch August 20, 2024 18:23
@StephenBrown2
Copy link
Contributor Author

It does look like GoReleaser failed though... https://github.com/flynshue/rhsm-cli/actions/runs/10475685459/job/29012891297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants