fix(holmes): remove capability-report alias

[flyingrobots]

Why

#637 scheduled removal of the temporary pre-canonical Holmes law capability ingest alias before any public Holmes law capability contract treats that alias as stable.

This is cleanup of an old compatibility bridge. It does not add Wesley-owned domain semantics.

Changes

• Reject wesley.capability-report/v1 as an unsupported law capability API version.
• Remove WESLEY_LEGACY_CAPABILITY_REPORT_API_VERSION from the Holmes domain and crate re-exports.
• Keep canonical wesley.law-capabilities/v1 ingest coverage green.
• Update wesley-holmes README and changelog signposts.

Risk

Low. The removed alias was explicitly temporary and internal to unpublished Holmes ingest work. Canonical wesley.law-capabilities/v1 behavior remains covered.

Backout

Revert commit d545c769 if a downstream unpublished fixture still needs migration time. Do not reintroduce the alias as a stable public contract.

Tracker Hygiene

Fixes #637. Rationale comment posted before closure path: #637 (comment)

Validation

• cargo test -p wesley-holmes --test law_capability_ingest law_capability_ingest_rejects_legacy_capability_report_alias
• cargo test -p wesley-holmes
• cargo fmt --check
• cargo clippy -p wesley-holmes --all-targets -- -D warnings
• cargo xtask docs-check
• git diff --check
• pnpm run preflight
• pre-push Rust product preflight
• PR fix(holmes): remove capability-report alias #644 GitHub Actions: green
• CodeRabbit: no actionable comments

[coderabbitai]

📝 Walkthrough

Walkthrough

Holmes now rejects the legacy wesley.capability-report/v1 alias during law capability ingest, keeps only wesley.law-capabilities/v1, removes the legacy constant from public re-exports, and updates the changelog, README, and ingest test.

Changes

Legacy capability alias removal

Layer / File(s)	Summary
Remove legacy alias exports crates/wesley-holmes/src/domain/law_capability.rs, crates/wesley-holmes/src/domain/mod.rs, crates/wesley-holmes/src/lib.rs	WESLEY_LEGACY_CAPABILITY_REPORT_API_VERSION is deleted from the domain file and removed from the module and crate re-export lists.
Reject legacy alias in ingest crates/wesley-holmes/src/application/law_capability_ingest.rs, crates/wesley-holmes/tests/law_capability_ingest.rs, CHANGELOG.md, crates/wesley-holmes/README.md	ingest_law_capabilities now accepts only WESLEY_LAW_CAPABILITIES_API_VERSION; the test expects rejection for the legacy alias, and the changelog and README reflect the updated rule.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A bunny hopped through Holmes today,
and nudged the old alias away.
Canonical is king, hop-hop hooray,
The tests now say "no" to the old buffet.
🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: removing the legacy capability-report alias.
Linked Issues check	✅ Passed	The changes stop accepting the legacy alias, remove the constant/export, keep canonical ingest covered, and update docs as required by #637.
Out of Scope Changes check	✅ Passed	The diff stays focused on alias removal, docs, exports, ingest validation, and the matching test update.
Description check	✅ Passed	The PR description covers the problem, rationale, changes, risk, backout, tracker hygiene, and validation, so it is mostly complete despite missing some template sections.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch v0.2.0/remove-capability-report-alias

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

🔍 The Case of Pull Request #644

Plain-English Readout

• Holmes (evidence investigation): Holmes says this change looks ready to ship.
• Watson (independent verification): Watson found verification concerns. Most important concern: No evidence citations were available for trust analysis.
• Moriarty (trend forecast): Moriarty does not have enough historical data yet to forecast readiness.

Suggested next actions

1. Resolve Watson’s verification concerns before trusting the Holmes verdict as final.

📚 Glossary (what the Holmes terms mean)

• HOLMES: Wesley’s main evidence investigation. It decides whether the cited proof is strong enough to justify shipping this commit.
• WATSON: An independent verification pass. It checks Holmes’s citations and score math instead of trusting them blindly.
• MORIARTY: A readiness forecast over time. It is advisory trend analysis, not the release gate itself.
• Schema coverage score (SCS): How much of the schema has direct supporting evidence across generated artifacts and cited proof.
• Test confidence index (TCI): How much test evidence exists for constraints, policies, relationships, and operations.
• Migration risk index (MRI): How risky the schema change is to roll out. Lower is better.
• Evidence trust: Whether the report is backed by exact citations, whole-file citations, or coarse references. Weak trust means the claim may be directionally right but not specific enough to trust blindly.
• Citation quality: A count of exact line-span citations versus whole-file or coarse references.
• ELEMENTARY: Ready to ship based on the current evidence.
• REQUIRES INVESTIGATION: More work or review is needed before shipping.
• YOU SHALL NOT PASS: Do not ship this change in its current state.

---

🕵️ SHA-lock HOLMES full report (click to expand)

🕵️ SHA-lock HOLMES Investigation

• Generated: 2026-01-01T00:00:00.000Z
• Commit SHA: 61863e2
• Bundle Version: 2.0.0

⚠️ Evidence valid only for commit 61863e2

🔍 Executive Deduction

"Watson, after careful examination of the evidence, I deduce..."

Weighted Completion: ██████████ 95.0%
Scores: SCS 95.0% · TCI 90.0% · MRI 10.0%
Verification Status: 2 claims verified
Citation Quality: 2 exact · 0 whole-file · 0 coarse
Evidence Trust: strong
Ship Verdict: ELEMENTARY

🧩 SCS Breakdown

Component	Score	Coverage
Sql	100.0%	1.00/1.00
Types	100.0%	1.00/1.00
Validation	100.0%	1.00/1.00
Tests	100.0%	1.00/1.00

🧪 TCI Breakdown

Component	Score	Coverage	Note
Unit Constraints	100.0%	1/1	N/A
Unit Rls	100.0%	1/1	N/A
Integration Relations	100.0%	1/1	N/A
E2e Ops	90.0%	9/10	N/A

⚠️ MRI Breakdown

Component	Risk Share	Points	Count
Drops	0.0%	0	0
Renames Without Uid	0.0%	0	0
Add Not Null Without Default	100.0%	1	1
Non Concurrent Indexes	0.0%	0	0

📊 The Weight of Evidence

"Observe, Watson, how not all features carry equal importance..."

Element	Weight	Status	Evidence	Strength	Deduction
schema	5	✅ Exact SQL & tests	test/fixtures/examples/.wesley-cache/shipme-fixture/tests.sql:1-1@61863e2	exact	Elementary!

🚪 Security & Performance Gates

"Elementary security measures, Watson..."

Gate	Status	Evidence	Holmes's Ruling
Migration Risk	✅	MRI: 10.0%	"Trivial risk"
Test Coverage	✅	TCI: 90.0%	"Excellent coverage"
Sensitive Fields	✅	0 fields	"All secured"
Evidence Quality	✅	2 exact · 0 whole-file · 0 coarse	"All 2 citations resolve to exact line spans."

📋 The Verdict

✅ ELEMENTARY - Ship immediately!
"The evidence is conclusive. No mysteries remain."

Signed and sealed,

• S. Holmes, Consulting Detective

[END OF INVESTIGATION FOR COMMIT 61863e2]

🧵 Command Run

• Run ID: run-fa4c0ea2-2425-4266-8414-a846bedf246f
• Transmutation: holmes-investigate
• Command: investigate
• Status: completed
• Ledger: /home/runner/work/wesley/wesley/test/fixtures/examples/.wesley-cache/ledger

---

🩺 Dr. WATSON full report (click to expand)

🩺 Dr. Watson's Independent Verification Report

Medical Examination of Evidence

• Examination Date: 2026-06-26T02:46:05.341Z
• Patient SHA: 61863e2

🔬 Citation Verification

"Let me examine each piece of evidence independently..."

• Citations Examined: 2
• Verified: 0 ✅
• Failed: 0 ❌
• Unable to Verify: 2
• Exact Subrange Citations: 0
• Whole-file Citations: 0
• Coarse Citations: 0
• Evidence Trust: missing
• Trust Note: No evidence citations were available for trust analysis.

Verification Rate: 0.0%

📊 Mathematical Verification

"I shall recalculate Holmes's arithmetic..."

Holmes claimed SCS: 95.0%
Watson calculates: 100.0%
Difference: ⚠️ Significant

🔍 Consistency Analysis

"Checking for contradictions in Holmes's deductions..."

✅ No logical inconsistencies detected

🩺 Dr. Watson's Medical Opinion

VERIFICATION: CONCERNS NOTED ⚠️

"While Holmes's methods are generally sound, I have noted some"
"discrepancies that warrant further investigation. No evidence citations were available for trust analysis."

Respectfully submitted,

• Dr. J. Watson, M.D.
  Medical Examiner & Verification Specialist

🧵 Command Run

• Run ID: run-d1474b64-bf22-4471-83da-97457ae16c22
• Transmutation: watson-verify
• Command: verify
• Status: completed
• Ledger: /home/runner/work/wesley/wesley/test/fixtures/examples/.wesley-cache/ledger

---

🔮 Professor MORIARTY full report (click to expand)

🧠 Professor Moriarty's Temporal Predictions

The Mathematics of Inevitability

• Analysis Date: 2026-06-26T02:46:34.004Z

INSUFFICIENT DATA

"I require at least two data points to predict the future."
"Run Wesley generate multiple times to build history."

🧵 Command Run

• Run ID: run-99318a82-eca6-4d0c-a387-0c0474eddb39
• Transmutation: moriarty-predict
• Command: predict
• Status: completed
• Ledger: /home/runner/work/wesley/wesley/test/fixtures/examples/.wesley-cache/ledger

---

Machine-readable reports: holmes-report.json · watson-report.json · moriarty-report.json (see workflow artifacts).

---

Filed at 221B Repository Street

[flyingrobots]

Code Lawyer Activity Summary

Item	Severity	Source	File / Area	Commit	Outcome
Review-thread discovery	P0 gate	PR	Review threads	n/a	No unresolved, non-outdated review threads found.
Global PR comments	P5 advisory	PR	CodeRabbit / HOLMES suite comments	n/a	Reviewed. CodeRabbit produced no actionable review comments; docstring warning is non-blocking because wesley-holmes enforces #![deny(missing_docs)] and local/CI clippy pass. HOLMES/WATSON advisory check completed successfully.
Self-audit diff	P0 gate	Self	origin/main...HEAD	d545c76	No logic, race, edge-case, nondeterminism, SoC, style, typing, or documentation blocker found. Diff stays scoped to removing the temporary alias.
Domain-free invariant	P0 gate	Self	Holmes law capability ingest	d545c76	No Wesley-owned product/domain semantics added. Change removes a retired compatibility string and keeps canonical wesley.law-capabilities/v1.
Local verification	P0 gate	Self	Full repo	d545c76	pnpm run preflight passed after fetch.
CI verification	P0 gate	PR	GitHub checks	d545c76	All checks green, including CodeRabbit.
Merge policy	P0 gate	PR	Review decision	n/a	Locked: reviewDecision is REVIEW_REQUIRED; approvals are 0.

No new self-discovered issues were found, so no fix commits were added during this Code Lawyer pass.

MERGE GATE: LOCKED

Blocking reasons:

• Required approval threshold is not met: 0 approvals, required >=2.
• GitHub review decision remains REVIEW_REQUIRED.

Ready once approvals are supplied or the owner explicitly authorizes an admin merge.