Repository navigation
Add Rust IR performance baseline - #521
Conversation
|
Warning Review limit reached
Your plan currently allows 1 review/hour. Refill in 16 minutes and 28 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR establishes a Rust IR performance baseline measurement system via ChangesRust IR Performance Baseline
Sequence Diagram(s)sequenceDiagram
participant User as User (pnpm perf:ir)
participant Script as measure-ir-performance.mjs
participant Wesley as Wesley CLI
participant Report as JSON/Markdown Report
User->>Script: CLI flags + fixture selection
Script->>Wesley: warmup run (schema lower)
Wesley->>Script: JSON output
Script->>Wesley: iteration 1 (schema lower)
Wesley->>Script: JSON output + duration
Script->>Wesley: iteration N (schema lower)
Wesley->>Script: JSON output + duration
Script->>Script: summarizeDurations() median/min/max
Script->>Report: render with metrics
Report->>User: JSON or Markdown evidence
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 The Case of Pull Request #521Plain-English Readout
Suggested next actions
📚 Glossary (what the Holmes terms mean)
🕵️ SHA-lock HOLMES full report (click to expand)🕵️ SHA-lock HOLMES Investigation
🔍 Executive Deduction"Watson, after careful examination of the evidence, I deduce..." Weighted Completion: ░░░░░░░░░░ 0.0% 🧩 SCS Breakdown
🧪 TCI Breakdown
|
| Component | Risk Share | Points | Count |
|---|---|---|---|
| Drops | 0% | 0 | 0 |
| Renames Without Uid | 0% | 0 | 0 |
| Add Not Null Without Default | 0% | 0 | 0 |
| Non Concurrent Indexes | 0% | 0 | 0 |
📊 The Weight of Evidence
"Observe, Watson, how not all features carry equal importance..."
| Element | Weight | Status | Evidence | Strength | Deduction |
|---|
🚪 Security & Performance Gates
"Elementary security measures, Watson..."
| Gate | Status | Evidence | Holmes's Ruling |
|---|---|---|---|
| Migration Risk | ✅ | MRI: 0.0% | "Trivial risk" |
| Test Coverage | TCI: 0.0% | "Theatrical tests!" | |
| Sensitive Fields | ✅ | 0 fields | "All secured" |
| Evidence Quality | ⛔ | 0 exact · 0 whole-file · 0 coarse | "No evidence citations were available for trust analysis." |
📋 The Verdict
⛔ YOU SHALL NOT PASS
"Critical evidence is missing! Return to your laboratory!"
Signed and sealed,
- S. Holmes, Consulting Detective
[END OF INVESTIGATION FOR COMMIT a190256]
🧵 Command Run
- Run ID: run-mpiopl07-yaioog
- Transmutation: holmes-investigate
- Command: investigate
- Status: completed
- Ledger: /home/runner/work/wesley/wesley/test/fixtures/examples/.wesley-cache/ledger
🩺 Dr. WATSON full report (click to expand)
🩺 Dr. Watson's Independent Verification Report
Medical Examination of Evidence
- Examination Date: 2026-05-23T18:31:33.768Z
- Patient SHA: a190256
🔬 Citation Verification
"Let me examine each piece of evidence independently..."
- Citations Examined: 0
- Verified: 0 ✅
- Failed: 0 ❌
- Unable to Verify: 0
- Exact Subrange Citations: 0
- Whole-file Citations: 0
- Coarse Citations: 0
- Evidence Trust: missing
- Trust Note: No evidence citations were available for trust analysis.
Verification Rate: 0.0%
📊 Mathematical Verification
"I shall recalculate Holmes's arithmetic..."
Holmes claimed SCS: 0.0%
Watson calculates: 0.0%
Difference: ✅ Negligible
🔍 Consistency Analysis
"Checking for contradictions in Holmes's deductions..."
🩺 Dr. Watson's Medical Opinion
VERIFICATION: CONCERNS NOTED
"While Holmes's methods are generally sound, I have noted some"
"discrepancies that warrant further investigation. No evidence citations were available for trust analysis."
Respectfully submitted,
- Dr. J. Watson, M.D.
Medical Examiner & Verification Specialist
🧵 Command Run
- Run ID: run-mpioq7we-fpqr80
- Transmutation: watson-verify
- Command: verify
- Status: completed
- Ledger: /home/runner/work/wesley/wesley/test/fixtures/examples/.wesley-cache/ledger
🔮 Professor MORIARTY full report (click to expand)
🧠 Professor Moriarty's Temporal Predictions
The Mathematics of Inevitability
- Analysis Date: 2026-05-23T18:32:08.497Z
🔮 Current State
SCS: ░░░░░░░░░░ 0.0%
TCI: ░░░░░░░░░░ 0.0%
MRI: 0.0% risk
Evidence Trust: missing
📈 Velocity Analysis
SCS Velocity: +0.00%/day
Git Activity (window): 24h · commits 12 (1 relevant) · ~12.00 commits/day
↳ Magnitude: ~498 relevant LOC/day across ~12.0 files/day
Activity Index: 30 / 100 (PR 0, Window 74)
Blended Velocity: +0.18%/day
Commit Size Burstiness: 0 / 100 (higher = more uneven commit sizes)
⏰ Completion Predictions
ETA: Cannot predict (insufficient velocity)
"At current velocity, completion is... improbable."
⚠️ Warnings
- Evidence trust is missing; No evidence citations were available for trust analysis.
🧪 Readiness EXPLAIN
- SCS ≥ 80% → FAIL ❌ (actual 0.0%)
- TCI ≥ 70% → FAIL ❌ (actual 0.0%)
- MRI ≤ 40% → PASS ✅ (actual 0.0%)
- CI Stability ≥ 90% (branch main) → PASS ✅ (actual 93% over ~168h)
- Evidence Trust ≥ moderate → FAIL ❌ (actual missing) — No evidence citations were available for trust analysis.
- Delivery context (last 168h): 0 issues closed · 9 PRs merged (informational, not gating)
Signals blend: SCS velocity (70%) + Git activity (30%, branch-first). Activity only suppresses false plateaus; it never inflates readiness.
📊 Historical Trajectory
05-23: ░░░░░░░░░░ 0.0%
05-23: ░░░░░░░░░░ 0.0%
05-23: ░░░░░░░░░░ 0.0%
"Every problem becomes elementary when reduced to mathematics"
— Professor Moriarty
🧵 Command Run
- Run ID: run-mpioqypb-8fwhc8
- Transmutation: moriarty-predict
- Command: predict
- Status: completed
- Ledger: /home/runner/work/wesley/wesley/test/fixtures/examples/.wesley-cache/ledger
Machine-readable reports: holmes-report.json · watson-report.json · moriarty-report.json (see workflow artifacts).
Filed at 221B Repository Street
|
@codex Self-audit finding
|
Summary
Testing
Also completed requested SCM/PR actions:
|
|
@codex Activity Summary
Validation after fix:
Merge gate is being re-evaluated on pushed head |
|
Thanks — I reviewed the trigger, PR metadata, and comment history. OutcomeNo further code changes are needed from me at this point:
Checks run
Since I did not make any new changes, I did not create a new commit and did not call |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 43ad6c0e5b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Around line 52-54: Update the CHANGELOG entry text for "Rust IR performance
baseline median" to explicitly state that for even-sized duration sample sets
the median is the "rounded midpoint" (i.e., the midpoint is rounded) instead of
saying "midpoint of the two central values" or "upper middle sample"; locate and
edit the bullet that begins with "**Rust IR performance baseline median**" and
replace the phrasing to read something like "Even-sized duration sample sets
report the median as the rounded midpoint of the two central values" to match
the implemented rounded behavior.
In `@scripts/measure-ir-performance.mjs`:
- Around line 215-219: Both spawnSync calls (in runLower and gitHead) lack
timeouts and can hang CI; add a timeout option to the spawnSync invocation
(e.g., timeout: 60_000 or use a shared constant like DEFAULT_SPAWN_TIMEOUT) and
handle timeout failures: after calling spawnSync check for result.error?.code
=== 'ETIMEDOUT' or a non-zero result.status/exit signal and surface a clear
error/log and throw or return a controlled failure instead of letting the
process hang. Update the spawnSync in runLower and the one in gitHead to include
the timeout and appropriate timeout/error handling logic.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 840aa75b-4a99-4ae1-920e-cbc09f7428b9
📒 Files selected for processing (15)
CHANGELOG.mddocs/BEARING.mddocs/design/0009-rust-core-and-wasm-capability-abi/rust-core-and-wasm-capability-abi.mddocs/design/0013-rust-ir-parity-sentinel/EVIDENCE_rust-core-performance-baseline.mddocs/design/0013-rust-ir-parity-sentinel/SOURCE_wesley-core-rs-ir-contract-and-fixtures.mddocs/design/0013-rust-ir-parity-sentinel/rust-ir-parity-sentinel.mddocs/design/README.mddocs/method/backlog/up-next/EVIDENCE_rust-core-binding-and-memory-baselines.mddocs/method/backlog/up-next/EVIDENCE_rust-core-performance-baseline.mddocs/method/backlog/up-next/README.mdpackage.jsonscripts/README.mdscripts/measure-ir-performance.mjsscripts/smoke/repo-bats-prepush.shtest/ir-performance-baseline.bats
💤 Files with no reviewable changes (1)
- docs/method/backlog/up-next/EVIDENCE_rust-core-performance-baseline.md
|
@codex Activity Summary
Validation after fix:
Resolved the three outdated review threads after replying with the fixing SHA/outcome. CI and CodeRabbit are re-running on pushed head |
SummaryNo new follow-up patch is required from me based on this trigger.
Validation / checks I ran
If you want, I can do a fresh pass specifically against current |
1 participant
Summary
Adds a v0 Rust IR performance baseline for the v0.0.6 compiler-truth lane.
pnpm perf:ir, backed byscripts/measure-ir-performance.mjs, to measure Rust CLIschema lowerwall-clock samples over the explicit valid IR fixture corpus.0013-rust-ir-parity-sentinelpacket and records the v0 report contract.Validation
BATS_LIB_PATH=test bats -t test/ir-performance-baseline.batspnpm perf:ir -- --iterations 1 --warmups 0 --jsonpnpm lintpnpm run format:checkgit diff --checkpnpm run lint:docs-whitespacepnpm parity:irbash scripts/smoke/repo-bats-prepush.shpnpm run preflightpnpm run validateNotes
The GitHub connector token was expired during PR creation, so this PR was opened through the authenticated
ghCLI fallback.Summary by CodeRabbit
Release Notes
New Features
pnpm perf:ircommand to measure Rust schema lowering wall-clock performance across fixture corpus.Bug Fixes
Documentation
Tests