Skip to content

feat(ops): QIR scaffold + --ops flag (doc-only behavior) - #40

Merged
flyingrobots merged 4 commits into
feat/rfc-query-ops-qirfrom
feat/qir-ops-scaffold
Oct 3, 2025
Merged

flyingrobots merged 4 commits into
feat/rfc-query-ops-qirfrom
feat/qir-ops-scaffold

Conversation

@flyingrobots

Copy link
Copy Markdown
Owner

This PR lands the smallest possible scaffold to de-risk the QIR feature proposed in RFC #19, without changing generation behavior:

  • core: minimal QIR node types + a unit test for deterministic construction
  • cli: --ops <dir> flag recognized in generate as a no-op validator (logs only)
  • host-node config: ops section and validation (folder/target/guardrails/RLS reliance)
  • docs: quick-start mentions experimental --ops and links the RFC draft

Notes

  • No runtime compilation or SQL emission is introduced here.
  • All changes are additive and behind a flag; existing workflows remain unaffected.
  • Next steps (separate PRs): QIR printer + single example op lowering (behind the flag).

Targets base branch: feat/rfc-query-ops-qir.

…ures: QueryPlan/Relation/Projection/Expr/Predicate\n- Deterministic alias allocator for tests\n- Unit test validates basic construction and EXISTS predicate
…ops <dir> option to generate\n- Validates presence of ops directory and common filenames\n- Logs informational message; no generation yet
…der=ops, target=function, RLS reliance=prefer\n- Guardrails: nestedList.requireLimit/requireOrderBy booleans\n- Validates target and rlsReliance
@flyingrobots flyingrobots added the enhancement New feature or request label Oct 3, 2025
@coderabbitai

coderabbitai Bot commented Oct 3, 2025

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@flyingrobots

Copy link
Copy Markdown
Owner Author

Docs-only behavior: this adds QIR node scaffolding, a no-op --ops flag, and config knobs. No generation changes or workflow edits. Targeting the feature branch to keep the surface area minimal.

@github-actions

github-actions Bot commented Oct 3, 2025

Copy link
Copy Markdown

🚢 SHIPME

[REALM] PASS — sha e3d4027

@flyingrobots
flyingrobots merged commit f1bfd63 into feat/rfc-query-ops-qir Oct 3, 2025
19 of 22 checks passed
@flyingrobots
flyingrobots deleted the feat/qir-ops-scaffold branch October 3, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant