Skip to content

test(holmes): cover weights command JSON output #105

Description

@flyingrobots

Rust-native audit disposition

Kept, but narrowed from the original October 2025 task.

The transitional @wesley/holmes CLI already exposes weights, weights:validate, and weights-validate, and current tests cover:

  • valid custom configuration
  • missing file failure
  • non-zero failure behavior

The remaining real gap is the --json <file> branch.

Current task

Add deterministic test coverage proving node packages/wesley-holmes/src/cli.mjs weights --json <file> writes the normalized weight config JSON and preserves the expected command behavior.

Acceptance criteria

  • A focused test invokes the weights command with a valid fixture and --json <path>.
  • The test asserts the JSON file exists and contains normalized default, substrings, directives, and overrides fields as applicable.
  • The test asserts the command still exits successfully and prints the existing human success line.
  • The test lives in the retained packages/wesley-holmes test suite and runs under the existing package test command.

Out of scope

  • New weight-policy features.
  • Native Rust Holmes scoring policy.
  • Unused-rule warnings; those were deliberately not retained from the old scoring roadmap.

Activity

  1. added this to the Go Public milestone on Oct 14, 2025
  2. added
    triage:bad-codeDebt intake that still needs scheduling, closure, or a repo move
    on Jun 24, 2026
  3. flyingrobots commented on Jun 25, 2026

    @flyingrobots
    OwnerAuthor

    Triage decision before state change:

    This issue appears to track: tests for HOLMES weights validation command.

    Current Wesley doctrine: Wesley core owns GraphQL -> deterministic, extensible IR and repo-local assurance around that contract. Domain-specific downstream semantics stay outside Wesley, but generic repo integrity, generic Holmes assurance, and extension-target coordination can stay here when scheduled to a real release lane.

    Decision: keep in Wesley and schedule for v0.3.0.

    Rationale: The command exists, but the tracked CLI-level success/failure/JSON coverage is not clearly satisfied; keep it with the Holmes hardening lane.

    Next action: remove triage:bad-code, add lane:v0.3.0, and assign the issue to Goalpost: Make It Truthful.

  4. added
    v0.3.0Scheduled work for the v0.3.0 release.
    and removed
    triage:bad-codeDebt intake that still needs scheduling, closure, or a repo move
    on Jun 25, 2026
  5. changed the title [-]test(holmes): cover weights validate command[/-] [+]test(holmes): cover weights command JSON output[/+] on Jul 6, 2026
  6. moved this from Todo to In Progress in Wesley Roadmapon Jul 6, 2026
  7. moved this from In Progress to Done in Wesley Roadmapon Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    holmesHOLMES scoring + workflowslegend:EVIDENCEEvidence/Holmes/CI/proof workpkg:wesley-holmestestsTest suite and coveragev0.3.0Scheduled work for the v0.3.0 release.

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions