CMake: add add_nostdlib() and apply to all targets (MSVC-gated); drop prior exec gating and purity flags

Author: flyingrobots

CMakeLists.txt

@@ -53,9 +53,11 @@ set(LIBGITLEDGER_HEADERS
 add_library(gitledger STATIC ${LIBGITLEDGER_SOURCES} ${LIBGITLEDGER_HEADERS})
 target_compile_options(gitledger PRIVATE ${PROJECT_WARNING_FLAGS})
 target_compile_definitions(gitledger PRIVATE GITLEDGER_BUILD=1)
-if(NOT MSVC)
-  target_link_options(gitledger PRIVATE -nostdlib)
-endif()
+function(add_nostdlib target)
+  if(NOT MSVC)
+    target_link_options(${target} PRIVATE -nostdlib)
+  endif()
+endfunction()
 
 if(GITLEDGER_VENDOR_LIBGIT2)
     message(FATAL_ERROR "Vendored libgit2 support is not implemented yet.\n"
@@ -109,36 +111,27 @@ target_include_directories(gitledger
 add_executable(gitledger_version_test tests/version_test.c)
 target_compile_options(gitledger_version_test PRIVATE ${PROJECT_WARNING_FLAGS})
 target_link_libraries(gitledger_version_test PRIVATE gitledger)
-if(GITLEDGER_EXEC_NOSTDLIB AND NOT MSVC)
-  target_link_options(gitledger_version_test PRIVATE -nostdlib)
-endif()
 
 add_executable(gitledger_tests libgitledger/tests/main.c)
 target_compile_options(gitledger_tests PRIVATE ${PROJECT_WARNING_FLAGS})
 target_link_libraries(gitledger_tests PRIVATE gitledger)
-if(GITLEDGER_EXEC_NOSTDLIB AND NOT MSVC)
-  target_link_options(gitledger_tests PRIVATE -nostdlib)
-endif()
 
 add_executable(mg-ledger libgitledger/cli/mg-ledger.c)
 target_compile_options(mg-ledger PRIVATE ${PROJECT_WARNING_FLAGS})
 target_link_libraries(mg-ledger PRIVATE gitledger)
-if(GITLEDGER_EXEC_NOSTDLIB AND NOT MSVC)
-  target_link_options(mg-ledger PRIVATE -nostdlib)
-endif()
 
 add_executable(gitledger_error_test tests/error_test.c)
 target_compile_options(gitledger_error_test PRIVATE ${PROJECT_WARNING_FLAGS})
 target_link_libraries(gitledger_error_test PRIVATE gitledger)
-if(GITLEDGER_EXEC_NOSTDLIB AND NOT MSVC)
-  target_link_options(gitledger_error_test PRIVATE -nostdlib)
-endif()
 
 include(CTest)
 if(BUILD_TESTING)
     add_test(NAME version COMMAND gitledger_version_test)
     add_test(NAME gitledger_cli_smoke COMMAND gitledger_tests)
     add_test(NAME error COMMAND gitledger_error_test)
 endif()
-# Optionally link executables with -nostdlib (non-MSVC); OFF by default to allow tests to run
-option(GITLEDGER_EXEC_NOSTDLIB "Link executables with -nostdlib on non-MSVC" OFF)
+add_nostdlib(gitledger)
+add_nostdlib(gitledger_version_test)
+add_nostdlib(gitledger_tests)
+add_nostdlib(mg-ledger)
+add_nostdlib(gitledger_error_test)