printf portability: replace %zu with PRIuMAX in tests and context diagnostics; tidy/format clean

Author: flyingrobots

libgitledger/core/context.c

@@ -1,5 +1,6 @@
 #include "gitledger/context.h"
 
+#include <inttypes.h>
 #include <stdatomic.h>
 #include <stdbool.h>
 #include <stdint.h>
@@ -138,9 +139,10 @@ static void context_debug_log_live_errors(size_t live_count)
         }
     char   buf[GITLEDGER_CONTEXT_DIAG_BUF];
     size_t length        = 0U;
-    int    written_chars = snprintf(
-        buf, sizeof buf,
-        "gitledger_context_destroy: %zu live error(s) at context teardown (leaked)\n", live_count);
+    int    written_chars = snprintf(buf, sizeof buf,
+                                    "gitledger_context_destroy: %" PRIuMAX
+                                    " live error(s) at context teardown (leaked)\n",
+                                    (uintmax_t) live_count);
     if (written_chars < 0)
         {
             const char* fallback =
@@ -177,10 +179,10 @@ static void context_register_error(gitledger_context_t* ctx, gitledger_error_t*
     if (!node)
         {
             /* Tracking failed — live errors may not be observed at teardown. */
-            fprintf(stderr,
-                    "GITLEDGER: context_register_error: alloc failed (ctx=%p, err=%p) — "
-                    "lifecycle guard may be impaired\n",
-                    (void*) ctx, (void*) err);
+            (void) fprintf(stderr,
+                           "GITLEDGER: context_register_error: alloc failed (ctx=%p, err=%p) — "
+                           "lifecycle guard may be impaired\n",
+                           (void*) ctx, (void*) err);
             return;
         }
     node->error = err;

tests/version_test.c

@@ -1,5 +1,6 @@
 #include "gitledger/version.h"
 
+#include <inttypes.h>
 #include <stddef.h>
 #include <stdio.h>
 #include <string.h>
@@ -14,8 +15,9 @@ int main(void)
 
     if (written != expected_len)
         {
-            fprintf(stderr, "version_test: expected snprintf length %zu, got %zu\n", expected_len,
-                    written);
+            fprintf(stderr,
+                    "version_test: expected snprintf length %" PRIuMAX ", got %" PRIuMAX "\n",
+                    (uintmax_t) expected_len, (uintmax_t) written);
             fprintf(stderr, "version_test: buffer contents >>%s<<\n", buffer);
             return 1;
         }
@@ -54,7 +56,8 @@ int main(void)
         size_t ret     = gitledger_semantic_version_snprintf(tiny, 0);
         if (ret != expected_len)
             {
-                fprintf(stderr, "version_test: n=0 expected %zu, got %zu\n", expected_len, ret);
+                fprintf(stderr, "version_test: n=0 expected %" PRIuMAX ", got %" PRIuMAX "\n",
+                        (uintmax_t) expected_len, (uintmax_t) ret);
                 return 1;
             }
         if (tiny[0] != 'X')
@@ -71,7 +74,8 @@ int main(void)
         size_t ret = gitledger_semantic_version_snprintf(small, sizeof small);
         if (ret != expected_len)
             {
-                fprintf(stderr, "version_test: n=5 expected %zu, got %zu\n", expected_len, ret);
+                fprintf(stderr, "version_test: n=5 expected %" PRIuMAX ", got %" PRIuMAX "\n",
+                        (uintmax_t) expected_len, (uintmax_t) ret);
                 return 1;
             }
         if (small[sizeof small - 1] != '\0')