Repository navigation
Add Echo Target IR lowering #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
2f734e1
Add Echo target IR lowering
flyingrobots 1f3923d
Connect Echo target IR to lowerability facts
flyingrobots 8177d39
Fix: use selected lowerability effects for target IR
flyingrobots e43fd11
Fix: preserve obstruction arms in target IR
flyingrobots fc3e93e
Fix: preserve intent results in target IR
flyingrobots dcc1f75
Fix: preserve effect bindings in target IR
flyingrobots 8cd979f
Fix: validate target operation profiles
flyingrobots c3f47b0
Fix: reject empty target IR intents
flyingrobots bdd3fb8
Fix: split target IR lowering helpers
flyingrobots 6f04432
Fix: gate target facts on lowerability status
flyingrobots 24b81d4
Fix: bind target facts to lowerability profile
flyingrobots f5cb14a
Fix: reject foreign target intrinsics
flyingrobots c2cfe1b
Fix: deduplicate native target selections
flyingrobots d503ede
Fix: reject unsupported Core ABI for target IR
flyingrobots 5b2d06c
Fix: reject unsupported Core capabilities
flyingrobots a5b0203
Fix: require digest-locked target profile
flyingrobots f60a803
Fix: scope target effect ambiguity to used effects
flyingrobots 3e1160d
Fix: document fallible target fact bridge
flyingrobots d6f9225
Fix: bind target bridge to lowerability operation profile
flyingrobots da8d3b3
Fix: reject empty Core modules for target IR
flyingrobots 7b0a961
Fix: bind target obstructions to lowerability evidence
flyingrobots c310e50
Fix: reject floating Core imports before target IR
flyingrobots f09869d
Fix: validate target profile reference in bridge
flyingrobots 13dd9e7
Fix: assert preserved target IR fields
flyingrobots c1ab041
Fix: cover target IR failure kinds
flyingrobots 9965199
Fix: format target IR tests
flyingrobots b2671fe
Fix: preserve Core obligations in target IR
flyingrobots File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an obstruction coordinate is declared only on a
SemanticEffectRequirement,check_effect_obligationsvalidates it and the report can still beNative, but this line copies only the aggregaterequirements.obstruction_coordinatesintoLowerabilityReport.TargetIrLoweringFacts::from_lowerability_reportthen derives target facts from that incomplete list, solower_to_target_irrejects a Core effect arm for that otherwise-checked obstruction asMissingObstruction. Include the checked per-effect obstruction coordinates, deduped, in the report or bridge.Useful? React with 👍 / 👎.